Message ID | 1511148687-24909-1-git-send-email-jasowang@redhat.com |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/6] Net patches Type: series Message-id: 1511148687-24909-1-git-send-email-jasowang@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1510926167-23326-1-git-send-email-mark.cave-ayland@ilande.co.uk -> patchew/1510926167-23326-1-git-send-email-mark.cave-ayland@ilande.co.uk * [new tag] patchew/1511148687-24909-1-git-send-email-jasowang@redhat.com -> patchew/1511148687-24909-1-git-send-email-jasowang@redhat.com Switched to a new branch 'test' 6d998dcb3e hw/net/vmxnet3: Fix code to work on big endian hosts, too e3b7d3045b net: Transmit zero UDP checksum as 0xFFFF 528693e2ba MAINTAINERS: Add missing entry for eepro100 emulation 434d3f0987 hw/net/eepro100: Fix endianness problem on big endian hosts c2e0b52dd7 Revert "Add new PCI ID for i82559a" 3e70742c2d colo-compare: fix the dangerous assignment === OUTPUT BEGIN === Checking PATCH 1/6: colo-compare: fix the dangerous assignment... Checking PATCH 2/6: Revert "Add new PCI ID for i82559a"... Checking PATCH 3/6: hw/net/eepro100: Fix endianness problem on big endian hosts... Checking PATCH 4/6: MAINTAINERS: Add missing entry for eepro100 emulation... Checking PATCH 5/6: net: Transmit zero UDP checksum as 0xFFFF... Checking PATCH 6/6: hw/net/vmxnet3: Fix code to work on big endian hosts, too... ERROR: spaces required around that ':' (ctx:VxV) #237: FILE: hw/net/vmxnet3.h:232: + u32 msscof:14; /* MSS, checksum offset, flags */ ^ ERROR: spaces required around that ':' (ctx:VxV) #238: FILE: hw/net/vmxnet3.h:233: + u32 ext1:1; ^ ERROR: spaces required around that ':' (ctx:VxV) #239: FILE: hw/net/vmxnet3.h:234: + u32 dtype:1; /* descriptor type */ ^ ERROR: spaces required around that ':' (ctx:VxV) #240: FILE: hw/net/vmxnet3.h:235: + u32 rsvd:1; ^ ERROR: spaces required around that ':' (ctx:VxV) #241: FILE: hw/net/vmxnet3.h:236: + u32 gen:1; /* generation bit */ ^ ERROR: spaces required around that ':' (ctx:VxV) #242: FILE: hw/net/vmxnet3.h:237: + u32 len:14; ^ ERROR: spaces required around that ':' (ctx:VxV) #250: FILE: hw/net/vmxnet3.h:239: + u32 len:14; ^ ERROR: spaces required around that ':' (ctx:VxV) #251: FILE: hw/net/vmxnet3.h:240: + u32 gen:1; /* generation bit */ ^ ERROR: spaces required around that ':' (ctx:VxV) #252: FILE: hw/net/vmxnet3.h:241: + u32 rsvd:1; ^ ERROR: spaces required around that ':' (ctx:VxV) #253: FILE: hw/net/vmxnet3.h:242: + u32 dtype:1; /* descriptor type */ ^ ERROR: spaces required around that ':' (ctx:VxV) #254: FILE: hw/net/vmxnet3.h:243: + u32 ext1:1; ^ ERROR: spaces required around that ':' (ctx:VxV) #255: FILE: hw/net/vmxnet3.h:244: + u32 msscof:14; /* MSS, checksum offset, flags */ ^ ERROR: trailing whitespace #261: FILE: hw/net/vmxnet3.h:249: + $ WARNING: architecture specific defines should be avoided #310: FILE: hw/net/vmxnet3.h:306: +#ifdef __BIG_ENDIAN_BITFIELD WARNING: architecture specific defines should be avoided #328: FILE: hw/net/vmxnet3.h:321: +#ifdef __BIG_ENDIAN_BITFIELD total: 13 errors, 2 warnings, 441 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On 20.11.2017 04:44, no-reply@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PULL 0/6] Net patches > Type: series > Message-id: 1511148687-24909-1-git-send-email-jasowang@redhat.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > t [tag update] patchew/1510926167-23326-1-git-send-email-mark.cave-ayland@ilande.co.uk -> patchew/1510926167-23326-1-git-send-email-mark.cave-ayland@ilande.co.uk > * [new tag] patchew/1511148687-24909-1-git-send-email-jasowang@redhat.com -> patchew/1511148687-24909-1-git-send-email-jasowang@redhat.com > Switched to a new branch 'test' > 6d998dcb3e hw/net/vmxnet3: Fix code to work on big endian hosts, too > e3b7d3045b net: Transmit zero UDP checksum as 0xFFFF > 528693e2ba MAINTAINERS: Add missing entry for eepro100 emulation > 434d3f0987 hw/net/eepro100: Fix endianness problem on big endian hosts > c2e0b52dd7 Revert "Add new PCI ID for i82559a" > 3e70742c2d colo-compare: fix the dangerous assignment > > === OUTPUT BEGIN === > Checking PATCH 1/6: colo-compare: fix the dangerous assignment... > Checking PATCH 2/6: Revert "Add new PCI ID for i82559a"... > Checking PATCH 3/6: hw/net/eepro100: Fix endianness problem on big endian hosts... > Checking PATCH 4/6: MAINTAINERS: Add missing entry for eepro100 emulation... > Checking PATCH 5/6: net: Transmit zero UDP checksum as 0xFFFF... > Checking PATCH 6/6: hw/net/vmxnet3: Fix code to work on big endian hosts, too... > ERROR: spaces required around that ':' (ctx:VxV) > #237: FILE: hw/net/vmxnet3.h:232: > + u32 msscof:14; /* MSS, checksum offset, flags */ > ^ > > ERROR: spaces required around that ':' (ctx:VxV) > #238: FILE: hw/net/vmxnet3.h:233: > + u32 ext1:1; > ^ Just for the records (again): These errors seem to be false positives from checkpatch. I originally tried to add spaces to all changed bitfields, but then checkpatch suddenly complains that spaces are not allowed there... Thomas
On 20 November 2017 at 03:31, Jason Wang <jasowang@redhat.com> wrote: > The following changes since commit 2e02083438962d26ef9dcc7100f3b378104183db: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2017-11-17 19:08:07 +0000) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to c527e0afcd7d719abc3a5ca5e4c8ac2fe48b999f: > > hw/net/vmxnet3: Fix code to work on big endian hosts, too (2017-11-20 11:08:00 +0800) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- Applied, thanks. -- PMM