From patchwork Tue Sep 12 21:34:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Llu=C3=ADs_Vilanova?= X-Patchwork-Id: 813088 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xsJ4v5Yphz9t39 for ; Wed, 13 Sep 2017 07:35:59 +1000 (AEST) Received: from localhost ([::1]:38731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drsqb-0005Ma-U9 for incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 17:35:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drsp2-0004HB-Vy for qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:34:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drsoy-0004pt-NR for qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:34:21 -0400 Received: from roura.ac.upc.es ([147.83.33.10]:51449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drsoy-0004pU-CK for qemu-devel@nongnu.org; Tue, 12 Sep 2017 17:34:16 -0400 Received: from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92]) by roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v8CLY7lj022446; Tue, 12 Sep 2017 23:34:07 +0200 Received: from localhost (unknown [31.210.187.58]) by correu-2.ac.upc.es (Postfix) with ESMTPSA id 30C1D259; Tue, 12 Sep 2017 23:34:02 +0200 (CEST) From: =?utf-8?b?TGx1w61z?= Vilanova To: qemu-devel@nongnu.org Date: Wed, 13 Sep 2017 00:34:01 +0300 Message-Id: <150525204093.15988.8421573656094243079.stgit@frigg.lan> X-Mailer: git-send-email 2.14.1 In-Reply-To: <150525010239.15988.8172586618197849619.stgit@frigg.lan> References: <150525010239.15988.8172586618197849619.stgit@frigg.lan> User-Agent: StGit/0.18 MIME-Version: 1.0 X-MIME-Autoconverted: from 8bit to quoted-printable by roura.ac.upc.es id v8CLY7lj022446 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 147.83.33.10 Subject: [Qemu-devel] [PATCH v5 08/22] instrument: [hmp] Add library loader X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Emilio G. Cota" , Markus Armbruster , Stefan Hajnoczi , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Lluís Vilanova --- hmp-commands.hx | 32 ++++++++++++++++++++++++++++++++ monitor.c | 39 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 1941e19932..2e8ebe8422 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1858,6 +1858,38 @@ ETEXI .sub_table = info_cmds, }, +#ifdef CONFIG_INSTRUMENT + { + .name = "instr-load", + .args_type = "path:F,id:s?,arg:s?", + .params = "path [id] [arg]", + .help = "load an instrumentation library", + .cmd = hmp_instr_load, + }, +#endif + +STEXI +@item instr-load @var{path} [@var{id}] [@var{arg}] +@findex instr-load +Load an instrumentation library. +ETEXI + +#ifdef CONFIG_INSTRUMENT + { + .name = "instr-unload", + .args_type = "id:s", + .params = "id", + .help = "unload an instrumentation library", + .cmd = hmp_instr_unload, + }, +#endif + +STEXI +@item instr-unload +@findex instr-unload +Unload an instrumentation library. +ETEXI + STEXI @end table ETEXI diff --git a/monitor.c b/monitor.c index e031aa2687..7b80d5351f 100644 --- a/monitor.c +++ b/monitor.c @@ -2323,6 +2323,45 @@ int monitor_fd_param(Monitor *mon, const char *fdname, Error **errp) return fd; } +#ifdef CONFIG_INSTRUMENT +static void hmp_instr_load(Monitor *mon, const QDict *qdict) +{ + Error *err = NULL; + const char *path = qdict_get_str(qdict, "path"); + const char *id = qdict_get_try_str(qdict, "id"); + const char *str = qdict_get_try_str(qdict, "arg"); + strList args; + + args.value = (char *)str; + args.next = NULL; + + InstrLoadResult *res = qmp_instr_load(path, + id != NULL, id, + args.value != NULL, &args, + &err); + if (err) { + error_report_err(err); + } else { + monitor_printf(mon, "Handle: %s\n", res->id); + monitor_printf(mon, "OK\n"); + } + qapi_free_InstrLoadResult(res); +} + +static void hmp_instr_unload(Monitor *mon, const QDict *qdict) +{ + Error *err = NULL; + const char *id = qdict_get_str(qdict, "id"); + + qmp_instr_unload(id, &err); + if (err) { + error_report_err(err); + } else { + monitor_printf(mon, "OK\n"); + } +} +#endif + /* Please update hmp-commands.hx when adding or changing commands */ static mon_cmd_t info_cmds[] = { #include "hmp-commands-info.h"