Message ID | 1502681591-31362-1-git-send-email-jasowang@redhat.com |
---|---|
State | New |
Headers | show |
On 14 August 2017 at 04:33, Jason Wang <jasowang@redhat.com> wrote: > The following changes since commit 9db6ffc76676731a25a5538ab71e8ca6ac234f80: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2017-08-11 15:11:50 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to 131f6055f1f0eba4cd2e862a8ff907dbde4d94d1: > > qemu-doc: Mention host_net_add/-remove in the deprecation chapter (2017-08-14 10:56:47 +0800) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > Mao Zhongyi (4): > net/rocker: Remove the dead error handling > net/rocker: Plug memory leak in pci_rocker_init() > net/rocker: Convert to realize() > net/rocker: Fix the unusual macro name > > Thomas Huth (1): > qemu-doc: Mention host_net_add/-remove in the deprecation chapter It's not clear to me why these should all be going into 2.10, especially since the date for rc3 is tomorrow and that in theory is our final rc. At this point we should only be taking patches that are fixes for significant bugs or bugs that are regressions since 2.9. (Docs changes are OK too.) Is there a good reason for putting in all these rocker patches that you haven't mentioned in the cover letter? They look like 2.11 material just judging by the patch titles. thanks -- PMM
On 2017年08月14日 14:51, Peter Maydell wrote: > On 14 August 2017 at 04:33, Jason Wang <jasowang@redhat.com> wrote: >> The following changes since commit 9db6ffc76676731a25a5538ab71e8ca6ac234f80: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2017-08-11 15:11:50 +0100) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to 131f6055f1f0eba4cd2e862a8ff907dbde4d94d1: >> >> qemu-doc: Mention host_net_add/-remove in the deprecation chapter (2017-08-14 10:56:47 +0800) >> >> ---------------------------------------------------------------- >> >> ---------------------------------------------------------------- >> Mao Zhongyi (4): >> net/rocker: Remove the dead error handling >> net/rocker: Plug memory leak in pci_rocker_init() >> net/rocker: Convert to realize() >> net/rocker: Fix the unusual macro name >> >> Thomas Huth (1): >> qemu-doc: Mention host_net_add/-remove in the deprecation chapter > It's not clear to me why these should all be going into 2.10, > especially since the date for rc3 is tomorrow and that in theory > is our final rc. At this point we should only be taking patches > that are fixes for significant bugs or bugs that are regressions > since 2.9. (Docs changes are OK too.) Is there a good reason > for putting in all these rocker patches that you haven't > mentioned in the cover letter? They look like 2.11 material > just judging by the patch titles. > > thanks > -- PMM Ok, let me send a V2 and remove the rocker patches. Thanks