Message ID | 149915849243.6295.4484103824675839071.stgit@frigg.lan |
---|---|
State | New |
Headers | show |
On 07/04/2017 03:54 AM, Lluís Vilanova wrote: > The existing optimizations makes it feasible to have them available on all > builds. While this change may feel trivial, I think it is a misnomer to include "[trivial]" in the subject line, and I also think it should not go in through qemu-trivial. The ideal trivial patch is one that can be applied in isolation, but your patch can only be applied as part of a series that includes the earlier optimizations that made this one possible.
Eric Blake writes: > On 07/04/2017 03:54 AM, Lluís Vilanova wrote: >> The existing optimizations makes it feasible to have them available on all >> builds. > While this change may feel trivial, I think it is a misnomer to include > "[trivial]" in the subject line, and I also think it should not go in > through qemu-trivial. The ideal trivial patch is one that can be > applied in isolation, but your patch can only be applied as part of a > series that includes the earlier optimizations that made this one possible. Ok. Does this mean I should send a new series without the trivial tag? Cheers, Lluis
On 07/07/2017 02:34 AM, Lluís Vilanova wrote: > Eric Blake writes: > >> On 07/04/2017 03:54 AM, Lluís Vilanova wrote: >>> The existing optimizations makes it feasible to have them available on all >>> builds. > >> While this change may feel trivial, I think it is a misnomer to include >> "[trivial]" in the subject line, and I also think it should not go in >> through qemu-trivial. The ideal trivial patch is one that can be >> applied in isolation, but your patch can only be applied as part of a >> series that includes the earlier optimizations that made this one possible. > > Ok. Does this mean I should send a new series without the trivial tag? Probably not worth the effort this time around, unless a maintainer specifically asks for it.
diff --git a/trace-events b/trace-events index bae63fdb1d..f9dbd7f509 100644 --- a/trace-events +++ b/trace-events @@ -106,7 +106,7 @@ vcpu guest_cpu_reset(void) # # Mode: user, softmmu # Targets: TCG(all) -disable vcpu tcg guest_mem_before(TCGv vaddr, uint8_t info) "info=%d", "vaddr=0x%016"PRIx64" info=%d" +vcpu tcg guest_mem_before(TCGv vaddr, uint8_t info) "info=%d", "vaddr=0x%016"PRIx64" info=%d" # @num: System call number. # @arg*: System call argument value. @@ -115,7 +115,7 @@ disable vcpu tcg guest_mem_before(TCGv vaddr, uint8_t info) "info=%d", "vaddr=0x # # Mode: user # Targets: TCG(all) -disable vcpu guest_user_syscall(uint64_t num, uint64_t arg1, uint64_t arg2, uint64_t arg3, uint64_t arg4, uint64_t arg5, uint64_t arg6, uint64_t arg7, uint64_t arg8) "num=0x%016"PRIx64" arg1=0x%016"PRIx64" arg2=0x%016"PRIx64" arg3=0x%016"PRIx64" arg4=0x%016"PRIx64" arg5=0x%016"PRIx64" arg6=0x%016"PRIx64" arg7=0x%016"PRIx64" arg8=0x%016"PRIx64 +vcpu guest_user_syscall(uint64_t num, uint64_t arg1, uint64_t arg2, uint64_t arg3, uint64_t arg4, uint64_t arg5, uint64_t arg6, uint64_t arg7, uint64_t arg8) "num=0x%016"PRIx64" arg1=0x%016"PRIx64" arg2=0x%016"PRIx64" arg3=0x%016"PRIx64" arg4=0x%016"PRIx64" arg5=0x%016"PRIx64" arg6=0x%016"PRIx64" arg7=0x%016"PRIx64" arg8=0x%016"PRIx64 # @num: System call number. # @ret: System call result value. @@ -124,4 +124,4 @@ disable vcpu guest_user_syscall(uint64_t num, uint64_t arg1, uint64_t arg2, uint # # Mode: user # Targets: TCG(all) -disable vcpu guest_user_syscall_ret(uint64_t num, uint64_t ret) "num=0x%016"PRIx64" ret=0x%016"PRIx64 +vcpu guest_user_syscall_ret(uint64_t num, uint64_t ret) "num=0x%016"PRIx64" ret=0x%016"PRIx64