| Message ID | 1496330073-51338-4-git-send-email-anton.nefedov@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
On 06/01/2017 10:14 AM, Anton Nefedov wrote: > Support the flag if the underlying BDS supports it > > Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com> > --- > block/blkdebug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Shouldn't other passthrough drivers (like raw-format.c) make this change as well? > > diff --git a/block/blkdebug.c b/block/blkdebug.c > index a5196e8..8b1401b 100644 > --- a/block/blkdebug.c > +++ b/block/blkdebug.c > @@ -415,7 +415,8 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags, > > bs->supported_write_flags = BDRV_REQ_FUA & > bs->file->bs->supported_write_flags; > - bs->supported_zero_flags = (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) & > + bs->supported_zero_flags = > + (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_ALLOCATE) & > bs->file->bs->supported_zero_flags; > ret = -EINVAL; > >
On 06/01/2017 10:50 PM, Eric Blake wrote: > On 06/01/2017 10:14 AM, Anton Nefedov wrote: >> Support the flag if the underlying BDS supports it >> >> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com> >> --- >> block/blkdebug.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Shouldn't other passthrough drivers (like raw-format.c) make this change > as well? > Right. Wonder why they even enumerate those instead of just bs->supported_zero_flags = bs->file->bs->supported_zero_flags; >> >> diff --git a/block/blkdebug.c b/block/blkdebug.c >> index a5196e8..8b1401b 100644 >> --- a/block/blkdebug.c >> +++ b/block/blkdebug.c >> @@ -415,7 +415,8 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags, >> >> bs->supported_write_flags = BDRV_REQ_FUA & >> bs->file->bs->supported_write_flags; >> - bs->supported_zero_flags = (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) & >> + bs->supported_zero_flags = >> + (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_ALLOCATE) & >> bs->file->bs->supported_zero_flags; >> ret = -EINVAL; >> >> > /Anton
diff --git a/block/blkdebug.c b/block/blkdebug.c index a5196e8..8b1401b 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -415,7 +415,8 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags, bs->supported_write_flags = BDRV_REQ_FUA & bs->file->bs->supported_write_flags; - bs->supported_zero_flags = (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) & + bs->supported_zero_flags = + (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_ALLOCATE) & bs->file->bs->supported_zero_flags; ret = -EINVAL;
Support the flag if the underlying BDS supports it Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com> --- block/blkdebug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)