From patchwork Mon Mar 27 07:21:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Xu X-Patchwork-Id: 743639 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vs59D0y8Lz9s1h for ; Mon, 27 Mar 2017 18:23:28 +1100 (AEDT) Received: from localhost ([::1]:44774 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csOzt-0006Yi-Es for incoming@patchwork.ozlabs.org; Mon, 27 Mar 2017 03:23:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csOzG-0006XU-PL for qemu-devel@nongnu.org; Mon, 27 Mar 2017 03:22:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csOzG-0002vm-1a for qemu-devel@nongnu.org; Mon, 27 Mar 2017 03:22:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51786) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csOzF-0002vW-SP for qemu-devel@nongnu.org; Mon, 27 Mar 2017 03:22:45 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EBA4E8E673 for ; Mon, 27 Mar 2017 07:22:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EBA4E8E673 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=peterx@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EBA4E8E673 Received: from pxdev.xzpeter.org (vpn1-7-78.pek2.redhat.com [10.72.7.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 67966BA889; Mon, 27 Mar 2017 07:22:40 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 27 Mar 2017 15:21:26 +0800 Message-Id: <1490599288-11751-4-git-send-email-peterx@redhat.com> In-Reply-To: <1490599288-11751-1-git-send-email-peterx@redhat.com> References: <1490599288-11751-1-git-send-email-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 27 Mar 2017 07:22:45 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "\\ Dr . David Alan Gilbert \\ " , peterx@redhat.com, Juan Quintela Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Dump the info in a single line is hard to read. Do it one per line. Also, the first "capabilities:" didn't help much. Let's remove it. CC: "Dr. David Alan Gilbert" Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert --- hmp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hmp.c b/hmp.c index edb8970..95eef8c 100644 --- a/hmp.c +++ b/hmp.c @@ -265,13 +265,11 @@ void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict) caps = qmp_query_migrate_capabilities(NULL); if (caps) { - monitor_printf(mon, "capabilities: "); for (cap = caps; cap; cap = cap->next) { - monitor_printf(mon, "%s: %s ", + monitor_printf(mon, "%s: %s\n", MigrationCapability_lookup[cap->value->capability], cap->value->state ? "on" : "off"); } - monitor_printf(mon, "\n"); } qapi_free_MigrationCapabilityStatusList(caps);