From patchwork Wed Mar 8 20:54:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brijesh Singh X-Patchwork-Id: 736738 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vdn6F2Y05z9sN5 for ; Thu, 9 Mar 2017 08:41:41 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="QEs0LXj7"; dkim-atps=neutral Received: from localhost ([::1]:58594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cljL1-0001oH-7Y for incoming@patchwork.ozlabs.org; Wed, 08 Mar 2017 16:41:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clj9L-0000Xe-2b for qemu-devel@nongnu.org; Wed, 08 Mar 2017 16:29:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clj9H-0006aG-S6 for qemu-devel@nongnu.org; Wed, 08 Mar 2017 16:29:35 -0500 Received: from mail-co1nam03on0044.outbound.protection.outlook.com ([104.47.40.44]:57248 helo=NAM03-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clj9H-0006a3-Dr for qemu-devel@nongnu.org; Wed, 08 Mar 2017 16:29:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Sayo2VDKisXhQcwn+rUuo1lpHxrX1gWfYVZfcB5ItKs=; b=QEs0LXj7fcJr699AgoY+SmijrftDXOuHu5eHKWZHGXtRrbp5CK/ATrsrhAlvxEmRwrN1uJUNstFVwb5RCjhYpqqf95lPzevIAqioQ32FjiLyROW8fi4HMQPKHOyxSDHukTAf1Bj7mWJ6tirAfpgNXj1dPaR2z5ngnpEVT2Djbw0= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from [127.0.1.1] (165.204.77.1) by CY4PR12MB1608.namprd12.prod.outlook.com (10.172.72.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Wed, 8 Mar 2017 20:54:37 +0000 From: Brijesh Singh To: , , , , , , , , Date: Wed, 8 Mar 2017 15:54:29 -0500 Message-ID: <148900646933.27090.3645480451819334521.stgit@brijesh-build-machine> In-Reply-To: <148900626714.27090.1616990932333159904.stgit@brijesh-build-machine> References: <148900626714.27090.1616990932333159904.stgit@brijesh-build-machine> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR18CA0029.namprd18.prod.outlook.com (10.173.208.15) To CY4PR12MB1608.namprd12.prod.outlook.com (10.172.72.17) X-MS-Office365-Filtering-Correlation-Id: 00ddf0b1-1672-4478-e988-08d46665558e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:CY4PR12MB1608; X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1608; 3:CnPxsnS6koT8fLlza0eO9m0cg5QKS/JEbcy8NMZdGdjXdBjCMKNl74HsCkiu3L2ZaVrgTd3J0106+aEv8e6HoXIhR/iWlUWl62Zqi4e3/fDZe5eybHlgGpmcrPcUlMjV8qYnwvsmWT6nj3yIGEAQ38FIf38AJnup+EDdb7R8G+DKCEzBGUwrvw0fnn+XX5QrD4oaJtloJHYWL2ZHsbXzaRS8ooUVBNcsQYFm/HhPjc9SQQs+AKgHI7a2BQTDmy9c3Feet0XPDAg/fQVDdBN/FzNjinMvwLk6TmrON6BP4P0=; 25:sf1taRd4RkFxjhj/caS9IzOGWznqY+zCZt6p9dCPW1YN6XklSWGPZbImacXmdHJKqBO3/8w7UzHGhmk5JAX8Moe32Ug4v6p/WBzSzv+2ShHmfRdE6kgETVXdfB5KE3BukMb++X9iO8Uc/2DmOoraTEPzeS0BDGouiroHVoA/5Q7EKlgkc66c3Zw6ITPPeF4VtF0GUlrEyd8E7XFBTakaDSPYNVJq9TBKvX62LB5OUS9jh3miRlf5ywoXgwbiZ5ZETcKGddvrPuZM/tIGIngy1QhLrMdOYC02RwZ17eyFHNImDtqdMQrHCMwP+YwoHrypRRiWYRpPe+PpUGA2Skqab0R6Md/ck6ia6mwYOs9HdmDLBb/jRXgZ4G79t9Y6pS/t2+n1RsVcKsz7o1tbfqKF25Rwc4QvJdgpD7tO75v3iCxxviX/i3OOGSfGi6fCpwJS X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1608; 31:p/ZkCqAtQXx3YOWmMU3y3FtFfbXoSdkYR1wIN1GXrdq6AC1HOuro+kVBv8a5sqJSdj3TyOL/eiys4GxuJCzSAenBzbyQgTW/VBgGm9z9CFeBKoanMPpFktFVpoRDuI88zhdr1MI86PpCQHIOHyGaS3i5/IhEUgsiARjZiB7UqaEYQQoyQjLtoKHAr/mrQsGju/GnUl0CXdIDcuI3gWYsFVlopvENdOrFidADfBnr0fGpqw+ctUm1J2N22/PzCpWV; 20:OanJX+MgTry0/y5kyE/mI1vi4dEOzSuN5QZO0RCKRCy6CpN7jq2YsCLvvOgoWrzMuaaevjHJGzfZRoqBerDO1xabFqYSzZ6FZszYTUo4EPIhlOuVSPmneT0NaqYhlL/ebosPaNcsogBmgcuW+KzeycHbYqO5YFbBfJxy3u29YaVOl/MH1R/h7Uu4ZAiqDqveP17AV51wVZ8jhOycR1Luse7XEdCneUcPD19DSGSLR8FoF8T3CkCfZuHGUebjpfIrQybFRdpehl/By1YwEarbAZfGjwAWeISgT2ZIyLQGF2nnwHFHe+2sflbQvYO2Xk5BAwBi3eAX5Oh9JYRFV6la90BezrLtsAmWt71Hk3aaNayK63gxZeP4j150dmEhrEcqUhKqIxZCAo/zrPQp7NaPsNmqt10OQWA61yIO4OeWcQILLo+yi+f8/FwRqlqNvRvB+8Sfh/co8M7slmvDVG29Lw1hbEwB57wOxCssjC7LUbRbt2PtZbSIEfMxdaNhTV4R X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(20161123558025)(20161123555025)(20161123564025)(6072148); SRVR:CY4PR12MB1608; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1608; X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1608; 4:wj8Xa0aoZ4cbBWxkl+qOjpLDyvNzu8zLpVXa/xPcxtO4L3Gm7yGyskoHMFbm5v5s36xj/K5lwY+upbVNH1fmSlpQ/aGzRhWToKx41rOmvZ8oPKXd74tzJXBvZkPkV5zDYv6bDBshzsnyF6nsBxLs3x+w9uRuNRFTsO3zybpDP5VRXYqoqhnO+QFq6s78svOeU2f/xBpXXd76Bo/BK8TrsQFu0e6AdTo6txah+eBNdjFm+kTCsLULrAgycCnzvUw8vqrm/8vcnh4N2h1ZyC4tzHs5xhHp1kGVefmUvKavG3rLXgRcNvYYkoFX8PQW0zRolp53Y5FMS3mjVh2cnBw9uA/fogNvHLLOcyhNRPV85a+vM5hphXj260hcrobYmHU7TPaWbYT4xs1KNaB0ENVUIy8o+Lr9cEUBp9OosrHFTfqdAm+eUfqTrB8guE8YSLUUd5cKZjiD1OtXcNc3zkTmcpL/S2IpXhxY4V28OKr4ULCNN5ZuZiazx+W9qBoFReT/qfeh/Nr8JWUtrMOxp6oZ8MpgYhzH3QAduuGf32NF492CVVgD/NXddDmnxs2xhi1X9xa7BxHUL2EM49Q7a/qUVgNTExd50BdKenkARZ6M4fAQoheT1iLztfPAE6YoYkXCokRhDJ9qkFP3WHJHVxGi5AMV76oCRjItsqT0VX/57MI= X-Forefront-PRVS: 02408926C4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(39410400002)(39860400002)(39450400003)(39840400002)(39850400002)(8676002)(3846002)(230700001)(53936002)(77096006)(6486002)(9686003)(7736002)(81166006)(54906002)(90366009)(25786008)(305945005)(86362001)(103116003)(5660300001)(2201001)(6116002)(33646002)(189998001)(47776003)(83506001)(2906002)(66066001)(2950100002)(33716001)(23676002)(6666003)(54356999)(76176999)(50986999)(38730400002)(42186005)(4326008)(50466002)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1608; H:[127.0.1.1]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxNjA4OzIzOnBCKzZHZDA3TG1wbndrTG5IWVdnN0pjRGxt?= =?utf-8?B?ZkpCMWx0dFFoVVdMaU5taVdUL3p1KzdmQ2xiTHA0bmpPcWJKK0lLc25KaHF1?= =?utf-8?B?ZFV1VjYyVS9pTTk2WjdyM292aVM1b0pTVUN3ckVtNWo0WFAvVDVsZzc1ajVx?= =?utf-8?B?aHVVL2hQWS9ud29kZWNPSE14UDZnYTBTMFMzMWZIOUtudVlUc0lsaTA0cnds?= =?utf-8?B?M2hhU1JrajYrUytNUWlCNERCRkFrMWFORVR3d2twT0xkZTI3Z0J0RUQrTkhL?= =?utf-8?B?Mk82cVhsYll6Ykg3RjNZQkpFS2F5TUVITGJ0MUIyMll3bkE2WEVSTG4wak93?= =?utf-8?B?T0owcDd0di96NWJ2WDFDRXFFSGM4OVU4TlBJYnErbFNEVXh4OGpuN0h5ckxT?= =?utf-8?B?QWEzcld4cHFubytTVWhHNUgwU2ZvQzAzMXJPZU84bG1COGQ4NkFFajhpeFdt?= =?utf-8?B?Y0dWOWRMVDFsSmtiKytWMGNOWFdJbktlelBtVXYvTG1ISno2djJEakpZQjc1?= =?utf-8?B?ZEordzFIVnhFMFhVQzZ5WXJBeW9DRHFhYUNHT0dTcExqdHh0cHlNT0YycEkv?= =?utf-8?B?Nnh1SHFQekZYUDVjNlpsSXhDTUEzK2xSVDBMbmRXYUl6VG9DeTNtSW9nUE94?= =?utf-8?B?dlJBeW5Fa3EyanJDVXdRbzJtZURiYzF5azdETTRORTREcXZMWVE4a1k3bXFS?= =?utf-8?B?U3Y2cXRLeXY4NysrbXBwZXhRVmhST3FJZnFzMktSalRoSTVCdGRZeTBUVWdu?= =?utf-8?B?R21BVzU1RW5JbUJtZFlReEQxc2pEUjBldFBKQ2hrdHMzYWt2UFlpczNxNWJn?= =?utf-8?B?UGUvWkpaU0RoSEVqUnBCL0c4Y2Q4ejBCcTFCdkhWaXFPTjBEZmNqTGRROHJZ?= =?utf-8?B?VHFMYmNkWlhLWFhTbDFDZjRlOG9UbzR3S0Y1UlNJajlVME54YXFtU2xtZjU2?= =?utf-8?B?d3FQanRnSjdIYmtzRjBVVnAvaFRvNll2YnJBZHVrNXNaeStmUnpSam5KV0Ju?= =?utf-8?B?QWFuQkFXaHFLMUdPNGorSUNIRkxjYmt5TWdYYUN5aDlqYUhmMkZqRXhXYWpt?= =?utf-8?B?OHdaQjRKM0Zrd1FqdkF4UzRVWmxDSENYVXlsZlZGMnNjSkViK1UxS0JXTTFK?= =?utf-8?B?UkN6NFpvUkZDNFJsaVFlQUpSZFlQY21CMDlaYmV3ZXh3TmNQaTE0MFNtVlht?= =?utf-8?B?MTRDV3FaM1ZpdERpK0gzaTRwRHdFN0RHVzZPVDZmb1hMemNuZHFQb2I1eTVR?= =?utf-8?B?Q3NQU1hjVUpyYm82UFVWbnNzb2NaNnFsWGNmbTBaQnhSWlRHZDd4bkhCWjNF?= =?utf-8?B?SlBSa05uUWtxWGgxVksrVXFzdldLSGE0UnZ3L2JobnlCclVtbGc1b0JXamFa?= =?utf-8?B?UUlyaWxDWG9HL09HWWIxQlBWSUhxM29xNFBYdHdTbWpxaUJZZThnZk15UWVI?= =?utf-8?B?R0xiNUxSM050REswdEVjSGRMMllPNWNrc0gxSHNpNFRodG5WejFCTWh6dEx3?= =?utf-8?B?NmlrUT09?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1608; 6:MG5a7hvtVgFx5gdU5urOQTLIecYAqFrP7FbWinvOqqgY70Im9Qv5KArqDOw3QYMVaExfOEsI+43Rj96n5Ggv15XT1zYeY3TUFDdpU4hniSRG4W26e6c03B+ZO15H4KFk1EwGnCmFZDDQNIMfTWHOXIPtFhxkBwh89pQCwcm1AJLycHdlG5cbJ7ymhodL85x2rKlmZhrY3VCtqTJdUWUd9ta8mOqCyWQ/mPTquJv8SL2eoN6abDYV0M3DhKeiMWyUUY/k8A2m8hfLVm3rszf05P2IZFQMPr8sSCaAxMTg0yaV3LgHs8UyT6sRGZg1A8X+weaiwQpZBRFYifE4dre7Pqwxx4v05TcYybzVXKGnszqC+H+qb/K2GbpPGNrGd6FMiFkikE8t70heoM9fXLCExRyir0N7OoI2l8v8xLSdsSU=; 5:GtMN4l8x/tq+p5uEU4eBti3jglv4ACPmxmXpv5q5h9O76K/qO3E42Kyf2989JmNslnxCnWLvOx2kJoeoZ+RT9WZlopmKjuvn1RvMM3pk5dDIxpaHuB2fcK9uQL6BViQSCBQ0Tedook0kMoXjHFsymeBPeVFH7b+LGoZWUBlR7uU=; 24:qhOKYC7kbxB263D42QP0hmCQAqg8wh4S63b5Sbl0esbY9e7JgH4eQyXU6DpZcO48iqw1vIaAAnCkxbo8aY2IlQ4n85orwqDI0pIkYRDJwsg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1608; 7:4f77YaFrta+6uM8dwG/6MQ8mvEfnZqPB8Qby91/PYtNvMMseVgOkxbLemg0LROFwHViquymJdRzxTYDL6j8VLyWp6ZDgrobQfQ5gIsIbdO80TqLnltfOmpjqfOV4F9TYCrQzfF95XLaVltTjD5j+NarLe9Rq+Rw0KLrRuh5ttsjrIt821KlfIwq6bjOs0ZlUShHPnf9EocIGnI1CGAFxKEH6aasGD/X36YUGXuyLDPh/7vCYt+Dz9WD42GzKl/CTcMMsweTR6EEXKiurghgW4DdvV1bZBHA3phVhAViW9rBALfUOACLJoHxyy70reRWFHxXcFU1vdWpBbsJI/h0gJw==; 20:UGdCq1q5Vst+/qRK+PtMtTkQmrwtOWG0qh2ziNidc9cEuNpia/FTl9n0bHdCNf4U98iAssgPebLX5YAdiAwxGZCt4nxExFIKCjIgY/mCTfSrqtcJXX2+if/p2ACfw7tu1IB6y5tvLJXdHBM6nKT1boeOzFy5wI23OPHZT09tX/Ga3HaEVXQ/7ydSS5HErVQFrZKmSRmKQINtho5QNXRwMjtRoVECoL7HUj0nplxT4rj/OO62XVNgHrIolZtjbfII X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2017 20:54:37.4085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1608 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.40.44 Subject: [Qemu-devel] [RFC PATCH v4 19/20] target/i386: clear memory encryption bit when walking SEV guest page table X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas.Lendacky@amd.com, brijesh.singh@amd.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" In SEV-enabled guest the pte entry will have C-bit set, we need to clear the C-bit when walking the page table. The C-bit position should be available in cpuid Fn8000_001f[EBX] Signed-off-by: Brijesh Singh --- target/i386/helper.c | 39 ++++++++++++++++++----- target/i386/monitor.c | 83 +++++++++++++++++++++++++++++++++++++------------ 2 files changed, 94 insertions(+), 28 deletions(-) diff --git a/target/i386/helper.c b/target/i386/helper.c index 05395d7..bbdef4d 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -22,6 +22,7 @@ #include "exec/exec-all.h" #include "sysemu/kvm.h" #include "kvm_i386.h" +#include "sysemu/sev.h" #ifndef CONFIG_USER_ONLY #include "sysemu/sysemu.h" #include "sysemu/hw_accel.h" @@ -1029,6 +1030,22 @@ do_check_protect_pse36: return 1; } +static uint64_t get_me_mask(void) +{ + uint64_t me_mask = 0; + + /* + * When SEV is active, Fn8000_001F[EBX] Bit 0:5 contains the C-bit position + */ + if (sev_enabled()) { + uint32_t pos; + pos = kvm_arch_get_supported_cpuid(kvm_state, 0x8000001f, 0, R_EBX); + me_mask = (1UL << (pos & 0x3f)); + } + + return ~me_mask; +} + hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) { X86CPU *cpu = X86_CPU(cs); @@ -1037,6 +1054,12 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) uint64_t pte; uint32_t page_offset; int page_size; + uint64_t me_mask; + + me_mask = get_me_mask(); + + /* In SEV guest, CR3 will have memory encryption bit set, clear it */ + env->cr[3] &= me_mask; if (!(env->cr[0] & CR0_PG_MASK)) { pte = addr & env->a20_mask; @@ -1061,7 +1084,7 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) if (la57) { pml5e_addr = ((env->cr[3] & ~0xfff) + (((addr >> 48) & 0x1ff) << 3)) & env->a20_mask; - pml5e = ldq_phys_debug(cs, pml5e_addr); + pml5e = ldq_phys_debug(cs, pml5e_addr) & me_mask; if (!(pml5e & PG_PRESENT_MASK)) { return -1; } @@ -1071,13 +1094,13 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) pml4e_addr = ((pml5e & PG_ADDRESS_MASK) + (((addr >> 39) & 0x1ff) << 3)) & env->a20_mask; - pml4e = ldq_phys_debug(cs, pml4e_addr); + pml4e = ldq_phys_debug(cs, pml4e_addr) & me_mask; if (!(pml4e & PG_PRESENT_MASK)) { return -1; } pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) << 3)) & env->a20_mask; - pdpe = ldq_phys_debug(cs, pdpe_addr); + pdpe = ldq_phys_debug(cs, pdpe_addr) & me_mask; if (!(pdpe & PG_PRESENT_MASK)) { return -1; } @@ -1092,14 +1115,14 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) { pdpe_addr = ((env->cr[3] & ~0x1f) + ((addr >> 27) & 0x18)) & env->a20_mask; - pdpe = ldq_phys_debug(cs, pdpe_addr); + pdpe = ldq_phys_debug(cs, pdpe_addr) & me_mask; if (!(pdpe & PG_PRESENT_MASK)) return -1; } pde_addr = ((pdpe & PG_ADDRESS_MASK) + (((addr >> 21) & 0x1ff) << 3)) & env->a20_mask; - pde = ldq_phys_debug(cs, pde_addr); + pde = ldq_phys_debug(cs, pde_addr) & me_mask; if (!(pde & PG_PRESENT_MASK)) { return -1; } @@ -1112,7 +1135,7 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) pte_addr = ((pde & PG_ADDRESS_MASK) + (((addr >> 12) & 0x1ff) << 3)) & env->a20_mask; page_size = 4096; - pte = ldq_phys_debug(cs, pte_addr); + pte = ldq_phys_debug(cs, pte_addr) & me_mask; } if (!(pte & PG_PRESENT_MASK)) { return -1; @@ -1122,7 +1145,7 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) /* page directory entry */ pde_addr = ((env->cr[3] & ~0xfff) + ((addr >> 20) & 0xffc)) & env->a20_mask; - pde = ldl_phys_debug(cs, pde_addr); + pde = ldl_phys_debug(cs, pde_addr) & me_mask; if (!(pde & PG_PRESENT_MASK)) return -1; if ((pde & PG_PSE_MASK) && (env->cr[4] & CR4_PSE_MASK)) { @@ -1131,7 +1154,7 @@ hwaddr x86_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) } else { /* page directory entry */ pte_addr = ((pde & ~0xfff) + ((addr >> 10) & 0xffc)) & env->a20_mask; - pte = ldl_phys_debug(cs, pte_addr); + pte = ldl_phys_debug(cs, pte_addr) & me_mask; if (!(pte & PG_PRESENT_MASK)) { return -1; } diff --git a/target/i386/monitor.c b/target/i386/monitor.c index 7c39e05..04982fa 100644 --- a/target/i386/monitor.c +++ b/target/i386/monitor.c @@ -27,6 +27,7 @@ #include "monitor/hmp-target.h" #include "hw/i386/pc.h" #include "sysemu/kvm.h" +#include "sysemu/sev.h" #include "hmp.h" @@ -59,6 +60,22 @@ static void print_pte(Monitor *mon, CPUArchState *env, hwaddr addr, pte & PG_RW_MASK ? 'W' : '-'); } +static uint64_t get_me_mask(void) +{ + uint64_t me_mask = 0; + + /* + * When SEV is active, Fn8000_001F[EBX] Bit 0:5 contains the C-bit position + */ + if (sev_enabled()) { + uint32_t pos; + pos = kvm_arch_get_supported_cpuid(kvm_state, 0x8000001f, 0, R_EBX); + me_mask = (1UL << (pos & 0x3f)); + } + + return ~me_mask; +} + static void tlb_info_32(Monitor *mon, CPUState *cs) { unsigned int l1, l2; @@ -96,15 +113,19 @@ static void tlb_info_pae32(Monitor *mon, CPUState *cs) uint64_t pdp_addr, pd_addr, pt_addr; X86CPU *cpu = X86_CPU(cs); CPUArchState *env = &cpu->env; + uint64_t me_mask; + + me_mask = get_me_mask(); pdp_addr = env->cr[3] & ~0x1f; + pdp_addr &= me_mask; for (l1 = 0; l1 < 4; l1++) { - pdpe = ldq_phys_debug(cs, pdp_addr + l1 * 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l1 * 8) & me_mask; pdpe = le64_to_cpu(pdpe); if (pdpe & PG_PRESENT_MASK) { pd_addr = pdpe & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - pde = ldq_phys_debug(cs, pd_addr + l2 * 8); + pde = ldq_phys_debug(cs, pd_addr + l2 * 8) & me_mask; pde = le64_to_cpu(pde); if (pde & PG_PRESENT_MASK) { if (pde & PG_PSE_MASK) { @@ -114,7 +135,8 @@ static void tlb_info_pae32(Monitor *mon, CPUState *cs) } else { pt_addr = pde & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - pte = ldq_phys_debug(cs, pt_addr + l3 * 8); + pte = ldq_phys_debug(cs, pt_addr + l3 * 8) + & me_mask; pte = le64_to_cpu(pte); if (pte & PG_PRESENT_MASK) { print_pte(mon, env, (l1 << 30) + (l2 << 21) @@ -131,6 +153,7 @@ static void tlb_info_pae32(Monitor *mon, CPUState *cs) } #ifdef TARGET_X86_64 + static void tlb_info_la48(Monitor *mon, CPUState *cs, uint64_t l0, uint64_t pml4_addr) { @@ -139,9 +162,12 @@ static void tlb_info_la48(Monitor *mon, CPUState *cs, uint64_t l1, l2, l3, l4; uint64_t pml4e, pdpe, pde, pte; uint64_t pdp_addr, pd_addr, pt_addr; + uint64_t me_mask; + + me_mask = get_me_mask(); for (l1 = 0; l1 < 512; l1++) { - pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8); + pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8) & me_mask; pml4e = le64_to_cpu(pml4e); if (!(pml4e & PG_PRESENT_MASK)) { continue; @@ -149,7 +175,7 @@ static void tlb_info_la48(Monitor *mon, CPUState *cs, pdp_addr = pml4e & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8) & me_mask; pdpe = le64_to_cpu(pdpe); if (!(pdpe & PG_PRESENT_MASK)) { continue; @@ -164,7 +190,7 @@ static void tlb_info_la48(Monitor *mon, CPUState *cs, pd_addr = pdpe & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - pde = ldq_phys_debug(cs, pd_addr + l3 * 8); + pde = ldq_phys_debug(cs, pd_addr + l3 * 8) & me_mask; pde = le64_to_cpu(pde); if (!(pde & PG_PRESENT_MASK)) { continue; @@ -179,7 +205,7 @@ static void tlb_info_la48(Monitor *mon, CPUState *cs, pt_addr = pde & 0x3fffffffff000ULL; for (l4 = 0; l4 < 512; l4++) { - pte = ldq_phys_debug(cs, pt_addr + l4 * 8); + pte = ldq_phys_debug(cs, pt_addr + l4 * 8) & me_mask; pte = le64_to_cpu(pte); if (pte & PG_PRESENT_MASK) { print_pte(mon, env, (l0 << 48) + (l1 << 39) + @@ -199,10 +225,14 @@ static void tlb_info_la57(Monitor *mon, CPUState *cs) uint64_t pml5_addr; X86CPU *cpu = X86_CPU(cs); CPUArchState *env = &cpu->env; + uint64_t me_mask; + + me_mask = get_me_mask(); pml5_addr = env->cr[3] & 0x3fffffffff000ULL; + pml5_addr &= me_mask; for (l0 = 0; l0 < 512; l0++) { - pml5e = ldq_phys_debug(cs, pml5_addr + l0 * 8); + pml5e = ldq_phys_debug(cs, pml5_addr + l0 * 8) & me_mask; pml5e = le64_to_cpu(pml5e); if (pml5e & PG_PRESENT_MASK) { tlb_info_la48(mon, cs, l0, pml5e & 0x3fffffffff000ULL); @@ -322,18 +352,22 @@ static void mem_info_pae32(Monitor *mon, CPUState *cs) hwaddr start, end; X86CPU *cpu = X86_CPU(cs); CPUArchState *env = &cpu->env; + uint64_t me_mask; + + me_mask = get_me_mask(); pdp_addr = env->cr[3] & ~0x1f; + pdp_addr &= me_mask; last_prot = 0; start = -1; for (l1 = 0; l1 < 4; l1++) { - pdpe = ldq_phys_debug(cs, pdp_addr + l1 * 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l1 * 8) & me_mask; pdpe = le64_to_cpu(pdpe); end = l1 << 30; if (pdpe & PG_PRESENT_MASK) { pd_addr = pdpe & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - pde = ldq_phys_debug(cs, pd_addr + l2 * 8); + pde = ldq_phys_debug(cs, pd_addr + l2 * 8) & me_mask; pde = le64_to_cpu(pde); end = (l1 << 30) + (l2 << 21); if (pde & PG_PRESENT_MASK) { @@ -344,7 +378,8 @@ static void mem_info_pae32(Monitor *mon, CPUState *cs) } else { pt_addr = pde & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - pte = ldq_phys_debug(cs, pt_addr + l3 * 8); + pte = ldq_phys_debug(cs, pt_addr + l3 * 8) + & me_mask; pte = le64_to_cpu(pte); end = (l1 << 30) + (l2 << 21) + (l3 << 12); if (pte & PG_PRESENT_MASK) { @@ -380,18 +415,22 @@ static void mem_info_la48(Monitor *mon, CPUState *cs) CPUArchState *env = &cpu->env; uint64_t pml4e, pdpe, pde, pte; uint64_t pml4_addr, pdp_addr, pd_addr, pt_addr, start, end; + uint64_t me_mask; + + me_mask = get_me_mask(); pml4_addr = env->cr[3] & 0x3fffffffff000ULL; + pml4_addr &= me_mask; last_prot = 0; start = -1; for (l1 = 0; l1 < 512; l1++) { - pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8); + pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8) & me_mask; pml4e = le64_to_cpu(pml4e); end = l1 << 39; if (pml4e & PG_PRESENT_MASK) { pdp_addr = pml4e & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8) & me_mask; pdpe = le64_to_cpu(pdpe); end = (l1 << 39) + (l2 << 30); if (pdpe & PG_PRESENT_MASK) { @@ -403,7 +442,8 @@ static void mem_info_la48(Monitor *mon, CPUState *cs) } else { pd_addr = pdpe & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - pde = ldq_phys_debug(cs, pd_addr + l3 * 8); + pde = ldq_phys_debug(cs, pd_addr + l3 * 8) + & me_mask; pde = le64_to_cpu(pde); end = (l1 << 39) + (l2 << 30) + (l3 << 21); if (pde & PG_PRESENT_MASK) { @@ -458,12 +498,15 @@ static void mem_info_la57(Monitor *mon, CPUState *cs) CPUArchState *env = &cpu->env; uint64_t pml5e, pml4e, pdpe, pde, pte; uint64_t pml5_addr, pml4_addr, pdp_addr, pd_addr, pt_addr, start, end; + uint64_t me_mask; - pml5_addr = env->cr[3] & 0x3fffffffff000ULL; + me_mask = get_me_mask(); + + pml5_addr = env->cr[3] & 0x3fffffffff000ULL & me_mask; last_prot = 0; start = -1; for (l0 = 0; l0 < 512; l0++) { - pml5e = ldq_phys_debug(cs, pml5_addr + l0 * 8); + pml5e = ldq_phys_debug(cs, pml5_addr + l0 * 8) & me_mask; pml4e = le64_to_cpu(pml5e); end = l0 << 48; if (!(pml5e & PG_PRESENT_MASK)) { @@ -474,7 +517,7 @@ static void mem_info_la57(Monitor *mon, CPUState *cs) pml4_addr = pml5e & 0x3fffffffff000ULL; for (l1 = 0; l1 < 512; l1++) { - pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8); + pml4e = ldq_phys_debug(cs, pml4_addr + l1 * 8) & me_mask; pml4e = le64_to_cpu(pml4e); end = (l0 << 48) + (l1 << 39); if (!(pml4e & PG_PRESENT_MASK)) { @@ -485,7 +528,7 @@ static void mem_info_la57(Monitor *mon, CPUState *cs) pdp_addr = pml4e & 0x3fffffffff000ULL; for (l2 = 0; l2 < 512; l2++) { - pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8); + pdpe = ldq_phys_debug(cs, pdp_addr + l2 * 8) & me_mask; pdpe = le64_to_cpu(pdpe); end = (l0 << 48) + (l1 << 39) + (l2 << 30); if (pdpe & PG_PRESENT_MASK) { @@ -504,7 +547,7 @@ static void mem_info_la57(Monitor *mon, CPUState *cs) pd_addr = pdpe & 0x3fffffffff000ULL; for (l3 = 0; l3 < 512; l3++) { - pde = ldq_phys_debug(cs, pd_addr + l3 * 8); + pde = ldq_phys_debug(cs, pd_addr + l3 * 8) & me_mask; pde = le64_to_cpu(pde); end = (l0 << 48) + (l1 << 39) + (l2 << 30) + (l3 << 21); if (pde & PG_PRESENT_MASK) { @@ -523,7 +566,7 @@ static void mem_info_la57(Monitor *mon, CPUState *cs) pt_addr = pde & 0x3fffffffff000ULL; for (l4 = 0; l4 < 512; l4++) { - pte = ldq_phys_debug(cs, pt_addr + l4 * 8); + pte = ldq_phys_debug(cs, pt_addr + l4 * 8) & me_mask; pte = le64_to_cpu(pte); end = (l0 << 48) + (l1 << 39) + (l2 << 30) + (l3 << 21) + (l4 << 12);