Message ID | 1486648058-520-5-git-send-email-clg@kaod.org |
---|---|
State | New |
Headers | show |
On 02/09/2017 10:47 AM, Cédric Le Goater wrote: > The size of a segment is not necessarily a power of 2. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/ssi/aspeed_smc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c > index 70177078a8f2..cb515730c5ad 100644 > --- a/hw/ssi/aspeed_smc.c > +++ b/hw/ssi/aspeed_smc.c > @@ -475,15 +475,15 @@ static uint32_t aspeed_smc_check_segment_addr(const AspeedSMCFlash *fl, > AspeedSegments seg; > > aspeed_smc_reg_to_segment(s->regs[R_SEG_ADDR0 + fl->id], &seg); > - if ((addr & (seg.size - 1)) != addr) { > + if ((addr % seg.size) != addr) { > qemu_log_mask(LOG_GUEST_ERROR, > "%s: invalid address 0x%08x for CS%d segment : " > "[ 0x%"HWADDR_PRIx" - 0x%"HWADDR_PRIx" ]\n", > s->ctrl->name, addr, fl->id, seg.addr, > seg.addr + seg.size); > + addr %= seg.size; > } > > - addr &= seg.size - 1; > return addr; > } > >
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 70177078a8f2..cb515730c5ad 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -475,15 +475,15 @@ static uint32_t aspeed_smc_check_segment_addr(const AspeedSMCFlash *fl, AspeedSegments seg; aspeed_smc_reg_to_segment(s->regs[R_SEG_ADDR0 + fl->id], &seg); - if ((addr & (seg.size - 1)) != addr) { + if ((addr % seg.size) != addr) { qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid address 0x%08x for CS%d segment : " "[ 0x%"HWADDR_PRIx" - 0x%"HWADDR_PRIx" ]\n", s->ctrl->name, addr, fl->id, seg.addr, seg.addr + seg.size); + addr %= seg.size; } - addr &= seg.size - 1; return addr; }
The size of a segment is not necessarily a power of 2. Signed-off-by: Cédric Le Goater <clg@kaod.org> --- hw/ssi/aspeed_smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)