| Message ID | 1484375301-159804-1-git-send-email-longpeng2@huawei.com |
|---|---|
| State | New |
| Headers | show |
> > From: longpeng > Sent: Saturday, January 14, 2017 2:28 PM > To: Gonglei (Arei) > Cc: Wubin (H); Zhoujian (jay, Euler); qemu-devel@nongnu.org; longpeng > Subject: [PATCH] cryptodev: setiv only when really need > > ECB mode cipher doesn't need IV, if we setiv for it then qemu > crypto API would report "Expected IV size 0 not **", so we should > setiv only when the cipher algos really need. > > Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com> > --- > backends/cryptodev-builtin.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > Queued. Thanks, -Gonglei
diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c index 82a068e..b24a299 100644 --- a/backends/cryptodev-builtin.c +++ b/backends/cryptodev-builtin.c @@ -320,10 +320,12 @@ static int cryptodev_builtin_sym_operation( sess = builtin->sessions[op_info->session_id]; - ret = qcrypto_cipher_setiv(sess->cipher, op_info->iv, - op_info->iv_len, errp); - if (ret < 0) { - return -VIRTIO_CRYPTO_ERR; + if (op_info->iv_len > 0) { + ret = qcrypto_cipher_setiv(sess->cipher, op_info->iv, + op_info->iv_len, errp); + if (ret < 0) { + return -VIRTIO_CRYPTO_ERR; + } } if (sess->direction == VIRTIO_CRYPTO_OP_ENCRYPT) {
ECB mode cipher doesn't need IV, if we setiv for it then qemu crypto API would report "Expected IV size 0 not **", so we should setiv only when the cipher algos really need. Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com> --- backends/cryptodev-builtin.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)