From patchwork Thu Jan 12 20:18:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 714641 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tzxvq2n2Yz9t1L for ; Fri, 13 Jan 2017 07:20:23 +1100 (AEDT) Received: from localhost ([::1]:36493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRlrB-0005TC-3L for incoming@patchwork.ozlabs.org; Thu, 12 Jan 2017 15:20:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRlpA-0003tw-MV for qemu-devel@nongnu.org; Thu, 12 Jan 2017 15:18:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRlp7-0004r5-Fk for qemu-devel@nongnu.org; Thu, 12 Jan 2017 15:18:16 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:60213) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cRlp7-0004qS-5U for qemu-devel@nongnu.org; Thu, 12 Jan 2017 15:18:13 -0500 Received: from Quad.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.183]) with ESMTPSA (Nemesis) id 0LuMJr-1cYP4C0XxP-011mUO; Thu, 12 Jan 2017 21:18:07 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Thu, 12 Jan 2017 21:18:00 +0100 Message-Id: <1484252284-29291-2-git-send-email-laurent@vivier.eu> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1484252284-29291-1-git-send-email-laurent@vivier.eu> References: <1484252284-29291-1-git-send-email-laurent@vivier.eu> X-Provags-ID: V03:K0:BJ96vF5ysRpDm7THfAbNwBp8303AIuCcxwReQA5GtQRDEgWOkCZ nLUutFAH44/ClY14488UNWype+Gx6A9XGsCevT1JgvuiY1QkU48O/DLVQJenVj5HzWYWC2u haJBjS7z++dFeaQw6k8FEQNYAJySkSq5k7xturkYPF6z60aAJecKiPLKl/Wh7EHqBfMagBw a4/8Vf01w8t20FqdY1CeQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:UFFuXD4Daj0=:+i6YNT8XYhWtdx0xCX8/Xm Wegp1PWvfuJwIAKjrCX0ftXcPQKxUuLhGYf7XKW58pKL62E2XmgrXc5g60RVogskqozLCWPRL iyusZauaw5IijpKAzAfNYoOlHTY1Oo6I0RbMZptFYdimt7w0+JDjqbrLwPpKalU3bbNmK2lVU mW+GWJWywRUi9qTKlDrEKtg+sXkcndaijmS2+d+2nb9Z7fIulbuiuQhXReJRBGoEdfN3dJeip 8+LCqB7HI4JzjxR7BhxcfF9fCssYKDWOhC3LsY3rMzfu6vO+lUlmYKqOS/gkNrlvC1F4tGmOB Au+kr2LCtKGZnTeA/z5R9oNUK8VET3BY9Z+UyRJ2ifd6D71UdND6TF7IilaLVakepXAUXiVke +E5rNqCAMEr5hPxTzqpDVXWtV5qFAQcr7pQi1kz7Vr9L+X3N2LBLC1uDX/maQFukSGoBbxEIm 8/pi5Ncb6Hk5kDsrpZ2eWIAS0ktUEA/v6QPDGhz1tlAGwsFWVh5H7mAN3bit885HktlxZ+6Ox TB/gw4H96ZQ6hyOUOVGYF+JKouxlj6yLvBz/I5OkRtQfNJCVr+jyb4DPNSaSP4M7Tc+Hdh2kF zKCzI1TLT9SbMQWPtp++75xUzuCdCVdot+rKHlWGglVHmwOQBjq05j0E8DS2VwkEKxsqCbbE9 F+HOzy7g6iFyn1AdJGZRWHTCB62WV5MNcCJwf34nMkrU6gRPbDWGWJCyPrN8baFj6uGk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.13 Subject: [Qemu-devel] [PATCH 1/5] target-m68k: fix bit operation with immediate value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , rth@twiddle.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" M680x0 bit operations with an immediate value use 9 bits of the 16bit value, while coldfire ones use only 8 bits. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 5f7357e..410f56a 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1801,9 +1801,16 @@ DISAS_INSN(bitop_im) op = (insn >> 6) & 3; bitnum = read_im16(env, s); - if (bitnum & 0xff00) { - disas_undef(env, s, insn); - return; + if (m68k_feature(s->env, M68K_FEATURE_M68000)) { + if (bitnum & 0xfe00) { + disas_undef(env, s, insn); + return; + } + } else { + if (bitnum & 0xff00) { + disas_undef(env, s, insn); + return; + } } SRC_EA(env, src1, opsize, 0, op ? &addr: NULL);