diff mbox

[Risu,v2,7/9] Add PPC64 in risu build system

Message ID 1478452528-13684-8-git-send-email-joserz@linux.vnet.ibm.com
State New
Headers show

Commit Message

Jose Ricardo Ziviani Nov. 6, 2016, 5:15 p.m. UTC
Recognizes PPC64 as a valid architecture and setup the environment
variables to compile code for that.

Signed-off-by: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
---
 configure | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Peter Maydell Feb. 18, 2017, 10:41 p.m. UTC | #1
On 6 November 2016 at 17:15, Jose Ricardo Ziviani
<joserz@linux.vnet.ibm.com> wrote:
> Recognizes PPC64 as a valid architecture and setup the environment
> variables to compile code for that.
>
> Signed-off-by: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
> ---
>  configure | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 748b48a..f81bdb5 100755
> --- a/configure
> +++ b/configure
> @@ -22,6 +22,12 @@ guess_arch() {
>          ARCH="arm"
>      elif check_define __aarch64__ ; then
>          ARCH="aarch64"
> +    elif check_define __powerpc64__ ; then
> +        if check_define __BIG_ENDIAN__; then
> +            ARCH="ppc64"
> +        else
> +            ARCH="ppc64le"
> +        fi

Does the BE ppc64 risu build work for you? I tried
installing the cross-compiler, but the build fails
because there's no risu_ppc64.c. (ppc64le works fine.)
If we don't support the big-endian variant yet maybe
we should drop it from the configure file.

thanks
-- PMM
Jose Ricardo Ziviani Feb. 21, 2017, 2:24 a.m. UTC | #2
On Sat, Feb 18, 2017 at 10:41:41PM +0000, Peter Maydell wrote:
> On 6 November 2016 at 17:15, Jose Ricardo Ziviani
> <joserz@linux.vnet.ibm.com> wrote:
> > Recognizes PPC64 as a valid architecture and setup the environment
> > variables to compile code for that.
> >
> > Signed-off-by: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
> > ---
> >  configure | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 748b48a..f81bdb5 100755
> > --- a/configure
> > +++ b/configure
> > @@ -22,6 +22,12 @@ guess_arch() {
> >          ARCH="arm"
> >      elif check_define __aarch64__ ; then
> >          ARCH="aarch64"
> > +    elif check_define __powerpc64__ ; then
> > +        if check_define __BIG_ENDIAN__; then
> > +            ARCH="ppc64"
> > +        else
> > +            ARCH="ppc64le"
> > +        fi
> 
> Does the BE ppc64 risu build work for you? I tried
> installing the cross-compiler, but the build fails
> because there's no risu_ppc64.c. (ppc64le works fine.)
> If we don't support the big-endian variant yet maybe
> we should drop it from the configure file.

I want it to work to but I focused the efforts on LE only, never tested
at all. I have a small patchset to send to you. I'll make an effort to fix BE as well,
it's worth it.

Thanks Peter!

> 
> thanks
> -- PMM
>
Peter Maydell Feb. 21, 2017, 9:59 a.m. UTC | #3
On 21 February 2017 at 02:24,  <joserz@linux.vnet.ibm.com> wrote:
> On Sat, Feb 18, 2017 at 10:41:41PM +0000, Peter Maydell wrote:
>>
>> Does the BE ppc64 risu build work for you? I tried
>> installing the cross-compiler, but the build fails
>> because there's no risu_ppc64.c. (ppc64le works fine.)
>> If we don't support the big-endian variant yet maybe
>> we should drop it from the configure file.
>
> I want it to work to but I focused the efforts on LE only, never tested
> at all. I have a small patchset to send to you. I'll make an effort to fix BE as well,
> it's worth it.

Up to you -- if you're not using BE yet then we can just as
easily disable it in configure for the moment, until you
have a need to get back to it.

thanks
-- PMM
diff mbox

Patch

diff --git a/configure b/configure
index 748b48a..f81bdb5 100755
--- a/configure
+++ b/configure
@@ -22,6 +22,12 @@  guess_arch() {
         ARCH="arm"
     elif check_define __aarch64__ ; then
         ARCH="aarch64"
+    elif check_define __powerpc64__ ; then
+        if check_define __BIG_ENDIAN__; then
+            ARCH="ppc64"
+        else
+            ARCH="ppc64le"
+        fi
     else
         echo "This cpu is not supported by risu. Try -h. " >&2
         exit 1
@@ -57,7 +63,7 @@  Some influential environment variables:
                prefixed with the given string.
 
   ARCH         force target architecture instead of trying to detect it.
-               Valid values=[arm|aarch64]
+               Valid values=[arm|aarch64|ppc64|ppc64le]
 
   CC           C compiler command
   CFLAGS       C compiler flags