From patchwork Tue Oct 25 19:03:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 686678 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3t3NVT6qxNz9snm for ; Wed, 26 Oct 2016 06:28:33 +1100 (AEDT) Received: from localhost ([::1]:57735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz7Og-0001Pc-5S for incoming@patchwork.ozlabs.org; Tue, 25 Oct 2016 15:28:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz717-0006HM-W4 for qemu-devel@nongnu.org; Tue, 25 Oct 2016 15:04:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz716-00087J-Ba for qemu-devel@nongnu.org; Tue, 25 Oct 2016 15:04:09 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:54006) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bz716-00086K-2D for qemu-devel@nongnu.org; Tue, 25 Oct 2016 15:04:08 -0400 Received: from Quad.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0MTQ5X-1cNcS41Ljr-00SN8C; Tue, 25 Oct 2016 21:03:39 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 25 Oct 2016 21:03:14 +0200 Message-Id: <1477422199-11208-19-git-send-email-laurent@vivier.eu> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477422199-11208-1-git-send-email-laurent@vivier.eu> References: <1477422199-11208-1-git-send-email-laurent@vivier.eu> X-Provags-ID: V03:K0:7nPJBofFaqMtFB69sfRcUi8x8ojVOCygC0HoM1WV+e4mUr3tD7/ MNfIqCR6djCaSOA1eJh2Vi/OVAIaBPk5v5WbibFPZHN9BlV5zOWhicZoMluyMCbFnXUxZHs SF/tkyZxe5FCYuW9txEDSBr3soeOo6Llhk8JTM06e57/5VgTvFLsFQ4aocYt+HlMVfXVDBa Aa4p0AhRG/SLLZi4uuvZA== X-UI-Out-Filterresults: notjunk:1; V01:K0:HRIrZgrEbpI=:VwuOowBAqcFgYIIcmXuVCE 4FiRtSzFowPKz3J0O9mcDsEKX93udq4HdPJqb3UHtc7nySpoAg8VcpLfqR0e7kawmB5lOmG7J eLoDnOHtA6ud/P/S8e9VIi5UqDjJzOCbkpS8hxtu90ZO72B9avBHsdMx3SCyzpOxAErXfLP0r NdjD9vc8Qoe6IB1Rye8W0BIruOcAYKN0AGmfVQGEObb0EKab6OiqOVPtyLlumrXhC0BP1Gj5E CEwS5s9I0of9D/RPt76Ie/S7O0Qn4EXj6xNTCKU4qLM+mKztP4vL+PmLBDZayxP7lksRE09wD rZEvVypqucQS+s2nyW1mEzSnnpynEOvNP7/yfn9Sjw2j43Q740VQnscwhFRY2bVMWmLO2MNZR qOmcs+aRF9jXTW2rT61s3VAFrORicREABvQHBgN1/DLfqamgmkTUAz9A08TNIL+HdJxXh4Tkm ik97KeVcyHu6UxCNAw5J7C6Hq9t2EspCOrmc9f9M9IrPVsxJumW/TS7c5CFjRrMxj/NGjTVVE q1F+aLn5aCPWvOVf9z/QeJxQ4K7uMFww5XcAfFUu8hwEKTjooE61Vvumpz25MoUXss29TYu2M +934PEb4ASyc4hVD2bvzHNl/rL1DJaYV/6Dg588kjqc2fL13WVpiBZYS/FV0iTx4+MtShHaKa +eLF9tSfEUq7F4Rgos9IXXE6oCV6Vz4MSe8P6cRuscs6+/cJZgLZi1YNM1GChQzXtcuo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.13 Subject: [Qemu-devel] [PULL 18/23] target-m68k: Remove incorrect clearing of cc_x X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , gerg@uclinux.org, schwab@linux-m68k.org, agraf@suse.de, Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson The CF docs certainly doesnt suggest this is true. Signed-off-by: Richard Henderson Signed-off-by: Laurent Vivier --- target-m68k/helper.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/target-m68k/helper.c b/target-m68k/helper.c index 1a54e66..a9974b1 100644 --- a/target-m68k/helper.c +++ b/target-m68k/helper.c @@ -207,19 +207,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op) break; case CC_OP_LOGICB: SET_NZ(dest, int8_t); - goto set_x; break; case CC_OP_LOGICW: SET_NZ(dest, int16_t); - goto set_x; break; case CC_OP_LOGIC: SET_NZ(dest, int32_t); -set_x: - if (!m68k_feature(env, M68K_FEATURE_M68000)) { - /* Unlike m68k, coldfire always clears the overflow bit. */ - env->cc_x = 0; - } break; case CC_OP_ADDB: SET_FLAGS_ADD(int8_t, uint8_t);