From patchwork Tue Oct 25 14:50:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 686529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3t3GmV0WXvz9t2p for ; Wed, 26 Oct 2016 02:10:18 +1100 (AEDT) Received: from localhost ([::1]:55288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz3Mk-0007zY-Qu for incoming@patchwork.ozlabs.org; Tue, 25 Oct 2016 11:10:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz33u-000059-1m for qemu-devel@nongnu.org; Tue, 25 Oct 2016 10:50:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz33p-00061d-PW for qemu-devel@nongnu.org; Tue, 25 Oct 2016 10:50:46 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:50470) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bz33p-00060Z-8c for qemu-devel@nongnu.org; Tue, 25 Oct 2016 10:50:41 -0400 Received: from Quad.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0LdIgf-1cgsBj0cXB-00iUBE; Tue, 25 Oct 2016 16:50:38 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 25 Oct 2016 16:50:16 +0200 Message-Id: <1477407021-30755-19-git-send-email-laurent@vivier.eu> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477407021-30755-1-git-send-email-laurent@vivier.eu> References: <1477407021-30755-1-git-send-email-laurent@vivier.eu> X-Provags-ID: V03:K0:Po1X5k8BYz2CXnsa+1HBq/Urx7zPgzUNvKhKTXiqRPbabMKoztw KnynHUkrMSPb84yeXqUMVNPtsJ/9Ne031iMXXZyGiBTi7uEQdI7drT+PUhCXWnA6NA/PR0n bodhYSzri3K4rWkhWcA3EpuSfpSnfzxjHrR8Lw28rSefK2SDNuS7wCyQpmRQLnCcWTnTs7b w25epDnco1OxtNOt2aKCQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:1E+3VH6iQYs=:zJ56pNePbn935Sn0gyBtVx 0xBQFwcs5myBKG1tWBnTveRk+rpNnym+t1nyJHSIOLhioMibXstMtXGVsgTfHVRPcUJNQ6M5P nICeMc9RqYK8Jr9W4iN60x4hwDMMyFLD7eqzQlGl2ubg64cclt+i/wJlBwqx8ZSX0kgWILuSl BBelJcqWRa5yWK6qhZ/ieMK71DlM3BCSCNNwgzMPm6Upt4jFKjDP4VfoEKCOo29zVEkW/NcSX 7pMZ8mhpVG8Mg/MYOJ51V8v9fCOqAaiCtnXPgx5fCMnbkksnzFG+NgVwjrPGakYbU/Y00Datr qhPSNPHdE3fA5blcCpvCYDaDMWFGI1+sot6pneijkErkvwMQj3mP+oOqmUTDXlt2a+rgutT6j Jqa6J+yPurfdARCZz97HfkdIW41kL6xYWNVAFXX67kunbQKujoRLMSaGoRplI2Kn5W5ID73UV 2owrYtNInY0yXEKXLo33rJx5hfLcpQfk1SHB7SpD47rxB/HuVBjagY+EHNIGsfTIy29SMS72P p+5+jO30KlPGX1gEy8i9dNNMDHN8mhnfDUnXax+GiWoN6ZFiVNMHtnjklI6eY5fecddbt+5GY yc52Aq/qKAtyZd+Y7sFGFcQ8+yeFSEhWXxWgxbG6uguoyB8cECB7QUIbMmFcpV++oLmmtKnHR LzNw61RGb2kAn+63anie4cjNp49H/ddwgqlXvk+1nnhrw+bgQB1BQ5VWk3lsosV2i8jU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.130 Subject: [Qemu-devel] [PATCH 18/23] target-m68k: Remove incorrect clearing of cc_x X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , gerg@uclinux.org, schwab@linux-m68k.org, agraf@suse.de, Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson The CF docs certainly doesnt suggest this is true. Signed-off-by: Richard Henderson Signed-off-by: Laurent Vivier --- target-m68k/helper.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/target-m68k/helper.c b/target-m68k/helper.c index 1a54e66..a9974b1 100644 --- a/target-m68k/helper.c +++ b/target-m68k/helper.c @@ -207,19 +207,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op) break; case CC_OP_LOGICB: SET_NZ(dest, int8_t); - goto set_x; break; case CC_OP_LOGICW: SET_NZ(dest, int16_t); - goto set_x; break; case CC_OP_LOGIC: SET_NZ(dest, int32_t); -set_x: - if (!m68k_feature(env, M68K_FEATURE_M68000)) { - /* Unlike m68k, coldfire always clears the overflow bit. */ - env->cc_x = 0; - } break; case CC_OP_ADDB: SET_FLAGS_ADD(int8_t, uint8_t);