| Message ID | 1474646996-30421-1-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 09/23/2016 12:09 PM, Thomas Huth wrote: > The folder include/hw/ide/ belongs to the IDE section. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d8a0cfc..acf6d6c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com> > L: qemu-block@nongnu.org > S: Supported > F: include/hw/ide.h > +F: include/hw/ide/ > F: hw/ide/ > F: hw/block/block.c > F: hw/block/cdrom.c > Ah, yeah. These got missed when they were moved over. Thanks. Reviewed-by: John Snow <jsnow@redhat.com>
Am 23.09.2016 um 18:42 hat John Snow geschrieben: > On 09/23/2016 12:09 PM, Thomas Huth wrote: > >The folder include/hw/ide/ belongs to the IDE section. > > > >Signed-off-by: Thomas Huth <thuth@redhat.com> > >--- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/MAINTAINERS b/MAINTAINERS > >index d8a0cfc..acf6d6c 100644 > >--- a/MAINTAINERS > >+++ b/MAINTAINERS > >@@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com> > > L: qemu-block@nongnu.org > > S: Supported > > F: include/hw/ide.h > >+F: include/hw/ide/ > > F: hw/ide/ > > F: hw/block/block.c > > F: hw/block/cdrom.c > > > > Ah, yeah. These got missed when they were moved over. Thanks. > > Reviewed-by: John Snow <jsnow@redhat.com> Who is supposed to merge this if you only give an R-b? And didn't we want to move the internal header files back to hw/ instead of the global include directory? Kevin
On 26.09.2016 10:22, Kevin Wolf wrote: > Am 23.09.2016 um 18:42 hat John Snow geschrieben: >> On 09/23/2016 12:09 PM, Thomas Huth wrote: >>> The folder include/hw/ide/ belongs to the IDE section. >>> >>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>> --- >>> MAINTAINERS | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index d8a0cfc..acf6d6c 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com> >>> L: qemu-block@nongnu.org >>> S: Supported >>> F: include/hw/ide.h >>> +F: include/hw/ide/ >>> F: hw/ide/ >>> F: hw/block/block.c >>> F: hw/block/cdrom.c >>> >> >> Ah, yeah. These got missed when they were moved over. Thanks. >> >> Reviewed-by: John Snow <jsnow@redhat.com> > > Who is supposed to merge this if you only give an R-b? I've CC:ed this patch to qemu-trivial, so I hope it will get picked up there if John does not want to apply this directly. Thomas
On 09/26/2016 05:39 AM, Thomas Huth wrote: > On 26.09.2016 10:22, Kevin Wolf wrote: >> Am 23.09.2016 um 18:42 hat John Snow geschrieben: >>> On 09/23/2016 12:09 PM, Thomas Huth wrote: >>>> The folder include/hw/ide/ belongs to the IDE section. >>>> >>>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>>> --- >>>> MAINTAINERS | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index d8a0cfc..acf6d6c 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com> >>>> L: qemu-block@nongnu.org >>>> S: Supported >>>> F: include/hw/ide.h >>>> +F: include/hw/ide/ >>>> F: hw/ide/ >>>> F: hw/block/block.c >>>> F: hw/block/cdrom.c >>>> >>> >>> Ah, yeah. These got missed when they were moved over. Thanks. >>> >>> Reviewed-by: John Snow <jsnow@redhat.com> >> >> Who is supposed to merge this if you only give an R-b? > > I've CC:ed this patch to qemu-trivial, so I hope it will get picked up > there if John does not want to apply this directly. > > Thomas > > Sorry, I didn't realize I would be expected to merge this myself. And I do want to move the files back, but I have to disentangle them and haven't done so yet. In the meantime, they should be recorded in MAINTAINERS. I'll stage this page in my IDE branch, thanks --js
On 09/26/2016 05:39 AM, Thomas Huth wrote: > On 26.09.2016 10:22, Kevin Wolf wrote: >> Am 23.09.2016 um 18:42 hat John Snow geschrieben: >>> On 09/23/2016 12:09 PM, Thomas Huth wrote: >>>> The folder include/hw/ide/ belongs to the IDE section. >>>> >>>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>>> --- >>>> MAINTAINERS | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index d8a0cfc..acf6d6c 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com> >>>> L: qemu-block@nongnu.org >>>> S: Supported >>>> F: include/hw/ide.h >>>> +F: include/hw/ide/ >>>> F: hw/ide/ >>>> F: hw/block/block.c >>>> F: hw/block/cdrom.c >>>> >>> >>> Ah, yeah. These got missed when they were moved over. Thanks. >>> >>> Reviewed-by: John Snow <jsnow@redhat.com> >> >> Who is supposed to merge this if you only give an R-b? > > I've CC:ed this patch to qemu-trivial, so I hope it will get picked up > there if John does not want to apply this directly. > > Thomas > > Thanks, applied to my IDE tree: https://github.com/jnsnow/qemu/commits/ide https://github.com/jnsnow/qemu.git --js
diff --git a/MAINTAINERS b/MAINTAINERS index d8a0cfc..acf6d6c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com> L: qemu-block@nongnu.org S: Supported F: include/hw/ide.h +F: include/hw/ide/ F: hw/ide/ F: hw/block/block.c F: hw/block/cdrom.c
The folder include/hw/ide/ belongs to the IDE section. Signed-off-by: Thomas Huth <thuth@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)