| Message ID | 1474608795-23058-1-git-send-email-peterx@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 23/09/2016 07:33, Peter Xu wrote: > It's 2.8 now, and maybe it's time to switch IOAPIC default version to > 0x20. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > > V2: > - keep compatible for qemu version <= 2.7 [Paolo] > > hw/intc/ioapic.c | 2 +- > include/hw/compat.h | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > index 31791b0..fd9208f 100644 > --- a/hw/intc/ioapic.c > +++ b/hw/intc/ioapic.c > @@ -416,7 +416,7 @@ static void ioapic_realize(DeviceState *dev, Error **errp) > } > > static Property ioapic_properties[] = { > - DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x11), > + DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x20), > DEFINE_PROP_END_OF_LIST(), > }; > > diff --git a/include/hw/compat.h b/include/hw/compat.h > index a1d6694..46412b2 100644 > --- a/include/hw/compat.h > +++ b/include/hw/compat.h > @@ -6,6 +6,10 @@ > .driver = "virtio-pci",\ > .property = "page-per-vq",\ > .value = "on",\ > + },{\ > + .driver = "ioapic",\ > + .property = "version",\ > + .value = "0x11",\ > }, > > #define HW_COMPAT_2_6 \ > Queued, thanks. Paolo
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 31791b0..fd9208f 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -416,7 +416,7 @@ static void ioapic_realize(DeviceState *dev, Error **errp) } static Property ioapic_properties[] = { - DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x11), + DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x20), DEFINE_PROP_END_OF_LIST(), }; diff --git a/include/hw/compat.h b/include/hw/compat.h index a1d6694..46412b2 100644 --- a/include/hw/compat.h +++ b/include/hw/compat.h @@ -6,6 +6,10 @@ .driver = "virtio-pci",\ .property = "page-per-vq",\ .value = "on",\ + },{\ + .driver = "ioapic",\ + .property = "version",\ + .value = "0x11",\ }, #define HW_COMPAT_2_6 \
It's 2.8 now, and maybe it's time to switch IOAPIC default version to 0x20. Signed-off-by: Peter Xu <peterx@redhat.com> --- V2: - keep compatible for qemu version <= 2.7 [Paolo] hw/intc/ioapic.c | 2 +- include/hw/compat.h | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-)