diff mbox

[v2,2/9] virtio-blk: turn virtio_blk_handle_request() into a static function

Message ID 147447702371.30952.12299213732680238463.stgit@bahia
State New
Headers show

Commit Message

Greg Kurz Sept. 21, 2016, 4:57 p.m. UTC 
It is only used locally since this commit:

03de2f527499 virtio-blk: do not use vring in dataplane

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/block/virtio-blk.c          |    2 +-
 include/hw/virtio/virtio-blk.h |    2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Cornelia Huck Sept. 22, 2016, 1:40 p.m. UTC | #1 
On Wed, 21 Sep 2016 18:57:03 +0200
Greg Kurz <groug@kaod.org> wrote:

> It is only used locally since this commit:
> 
> 03de2f527499 virtio-blk: do not use vring in dataplane
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  hw/block/virtio-blk.c          |    2 +-
>  include/hw/virtio/virtio-blk.h |    2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Stefan Hajnoczi Sept. 23, 2016, 12:45 p.m. UTC | #2 
On Wed, Sep 21, 2016 at 06:57:03PM +0200, Greg Kurz wrote:
> It is only used locally since this commit:
> 
> 03de2f527499 virtio-blk: do not use vring in dataplane
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  hw/block/virtio-blk.c          |    2 +-
>  include/hw/virtio/virtio-blk.h |    2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff mbox

Patch

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 3a6112fbf4c4..09579968ad89 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -468,7 +468,7 @@  static bool virtio_blk_sect_range_ok(VirtIOBlock *dev,
     return true;
 }
 
-void virtio_blk_handle_request(VirtIOBlockReq *req, MultiReqBuffer *mrb)
+static void virtio_blk_handle_request(VirtIOBlockReq *req, MultiReqBuffer *mrb)
 {
     uint32_t type;
     struct iovec *in_iov = req->elem.in_sg;
diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index 180bd8db5df2..07992a96763d 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -84,8 +84,6 @@  void virtio_blk_init_request(VirtIOBlock *s, VirtQueue *vq,
                              VirtIOBlockReq *req);
 void virtio_blk_free_request(VirtIOBlockReq *req);
 
-void virtio_blk_handle_request(VirtIOBlockReq *req, MultiReqBuffer *mrb);
-
 void virtio_blk_submit_multireq(BlockBackend *blk, MultiReqBuffer *mrb);
 
 void virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq);