From patchwork Tue Jul 12 16:23:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 647504 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rpnbz2NmFz9s9x for ; Wed, 13 Jul 2016 02:34:23 +1000 (AEST) Received: from localhost ([::1]:42068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN0dY-0004lG-Vv for incoming@patchwork.ozlabs.org; Tue, 12 Jul 2016 12:34:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN0TA-0007kB-HU for qemu-devel@nongnu.org; Tue, 12 Jul 2016 12:23:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bN0T4-0003dV-P3 for qemu-devel@nongnu.org; Tue, 12 Jul 2016 12:23:35 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:43408 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN0T4-0003dQ-FU for qemu-devel@nongnu.org; Tue, 12 Jul 2016 12:23:30 -0400 Received: (qmail 29058 invoked by uid 89); 12 Jul 2016 16:23:29 -0000 Received: from [195.62.97.28] by client-16-kamp (envelope-from , uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.99.2/21890. hbedv: 8.3.40.44/7.12.99.34. avast: 1.2.2/16071101. spamassassin: 3.4.1. Clear:RC:1(195.62.97.28):. Processed in 0.176878 secs); 12 Jul 2016 16:23:29 -0000 Received: from smtp.kamp.de (HELO submission.kamp.de) ([195.62.97.28]) by mx01.kamp.de with ESMTPS (DHE-RSA-AES256-GCM-SHA384 encrypted); 12 Jul 2016 16:23:27 -0000 X-GL_Whitelist: yes Received: (qmail 2557 invoked from network); 12 Jul 2016 16:23:12 -0000 Received: from lieven-pc.kamp-intra.net (HELO lieven-pc) (relay@kamp.de@::ffff:172.21.12.60) by submission.kamp.de with ESMTPS (DHE-RSA-AES256-GCM-SHA384 encrypted) ESMTPA; 12 Jul 2016 16:23:12 -0000 Received: by lieven-pc (Postfix, from userid 1000) id C379720643; Tue, 12 Jul 2016 18:23:10 +0200 (CEST) From: Peter Lieven To: qemu-devel@nongnu.org Date: Tue, 12 Jul 2016 18:23:04 +0200 Message-Id: <1468340586-19304-5-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1468340586-19304-1-git-send-email-pl@kamp.de> References: <1468340586-19304-1-git-send-email-pl@kamp.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a02:248:0:51::16 Subject: [Qemu-devel] [PATCH V5 4/6] coroutine-sigaltstack: use helper for allocating stack memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, armbru@redhat.com, Peter Lieven , dgilbert@redhat.com, mreitz@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven Reviewed-by: Stefan Hajnoczi --- util/coroutine-sigaltstack.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 9c2854c..ccf4861 100644 --- a/util/coroutine-sigaltstack.c +++ b/util/coroutine-sigaltstack.c @@ -143,7 +143,6 @@ static void coroutine_trampoline(int signal) Coroutine *qemu_coroutine_new(void) { - const size_t stack_size = COROUTINE_STACK_SIZE; CoroutineUContext *co; CoroutineThreadState *coTS; struct sigaction sa; @@ -164,7 +163,7 @@ Coroutine *qemu_coroutine_new(void) */ co = g_malloc0(sizeof(*co)); - co->stack = g_malloc(stack_size); + co->stack = qemu_alloc_stack(COROUTINE_STACK_SIZE); co->base.entry_arg = &old_env; /* stash away our jmp_buf */ coTS = coroutine_get_thread_state(); @@ -189,7 +188,7 @@ Coroutine *qemu_coroutine_new(void) * Set the new stack. */ ss.ss_sp = co->stack; - ss.ss_size = stack_size; + ss.ss_size = COROUTINE_STACK_SIZE; ss.ss_flags = 0; if (sigaltstack(&ss, &oss) < 0) { abort(); @@ -253,7 +252,7 @@ void qemu_coroutine_delete(Coroutine *co_) { CoroutineUContext *co = DO_UPCAST(CoroutineUContext, base, co_); - g_free(co->stack); + qemu_free_stack(co->stack, COROUTINE_STACK_SIZE); g_free(co); }