From patchwork Mon Jul 11 09:08:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 646884 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rnzqM0t7Lz9sXx for ; Mon, 11 Jul 2016 19:11:27 +1000 (AEST) Received: from localhost ([::1]:59076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMXFN-0000M5-3U for incoming@patchwork.ozlabs.org; Mon, 11 Jul 2016 05:11:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMXCT-0004Zv-3e for qemu-devel@nongnu.org; Mon, 11 Jul 2016 05:08:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMXCQ-0003EK-MF for qemu-devel@nongnu.org; Mon, 11 Jul 2016 05:08:23 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:33334 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMXCQ-0003E9-DS for qemu-devel@nongnu.org; Mon, 11 Jul 2016 05:08:22 -0400 Received: (qmail 32107 invoked by uid 89); 11 Jul 2016 09:08:21 -0000 Received: from [195.62.97.28] by client-16-kamp (envelope-from , uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.99.2/21882. hbedv: 8.3.40.44/7.12.99.34. avast: 1.2.2/16071100. spamassassin: 3.4.1. Clear:RC:1(195.62.97.28):. Processed in 0.408813 secs); 11 Jul 2016 09:08:21 -0000 Received: from smtp.kamp.de (HELO submission.kamp.de) ([195.62.97.28]) by mx01.kamp.de with ESMTPS (DHE-RSA-AES256-GCM-SHA384 encrypted); 11 Jul 2016 09:08:18 -0000 X-GL_Whitelist: yes Received: (qmail 28609 invoked from network); 11 Jul 2016 09:08:12 -0000 Received: from lieven-pc.kamp-intra.net (HELO lieven-pc) (relay@kamp.de@::ffff:172.21.12.60) by submission.kamp.de with ESMTPS (DHE-RSA-AES256-GCM-SHA384 encrypted) ESMTPA; 11 Jul 2016 09:08:12 -0000 Received: by lieven-pc (Postfix, from userid 1000) id D563720A24; Mon, 11 Jul 2016 11:08:06 +0200 (CEST) From: Peter Lieven To: qemu-devel@nongnu.org Date: Mon, 11 Jul 2016 11:08:02 +0200 Message-Id: <1468228082-7492-7-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1468228082-7492-1-git-send-email-pl@kamp.de> References: <1468228082-7492-1-git-send-email-pl@kamp.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a02:248:0:51::16 Subject: [Qemu-devel] [PATCH V4 6/6] coroutine: reduce stack size to 64kB X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, armbru@redhat.com, Peter Lieven , dgilbert@redhat.com, mreitz@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added in qemu_alloc_stack will catch a potential stack overflow introduced by this commit. Signed-off-by: Peter Lieven --- include/qemu/coroutine_int.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_int.h index eac323a..f84d777 100644 --- a/include/qemu/coroutine_int.h +++ b/include/qemu/coroutine_int.h @@ -28,7 +28,7 @@ #include "qemu/queue.h" #include "qemu/coroutine.h" -#define COROUTINE_STACK_SIZE (1 << 20) +#define COROUTINE_STACK_SIZE (1 << 16) typedef enum { COROUTINE_YIELD = 1,