diff mbox

[v2,1/2] main-loop: check return value before using

Message ID 1467799740-26079-2-git-send-email-caoj.fnst@cn.fujitsu.com
State New
Headers show

Commit Message

Cao jin July 6, 2016, 10:08 a.m. UTC 
pointer 'qemu_aio_context' should be checked first before it is used.
qemu_bh_new() will use it.

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 main-loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paolo Bonzini July 6, 2016, 11:03 a.m. UTC | #1 
On 06/07/2016 12:08, Cao jin wrote:
> pointer 'qemu_aio_context' should be checked first before it is used.
> qemu_bh_new() will use it.
> 
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  main-loop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/main-loop.c b/main-loop.c
> index 89a6994..6a7f8d3 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -154,11 +154,11 @@ int qemu_init_main_loop(Error **errp)
>      }
>  
>      qemu_aio_context = aio_context_new(&local_error);
> -    qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
>      if (!qemu_aio_context) {
>          error_propagate(errp, local_error);
>          return -EMFILE;
>      }
> +    qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
>      gpollfds = g_array_new(FALSE, FALSE, sizeof(GPollFD));
>      src = aio_get_g_source(qemu_aio_context);
>      g_source_attach(src, NULL);
> 

Looks good, thanks!

Paolo
diff mbox

Patch

diff --git a/main-loop.c b/main-loop.c
index 89a6994..6a7f8d3 100644
--- a/main-loop.c
+++ b/main-loop.c
@@ -154,11 +154,11 @@  int qemu_init_main_loop(Error **errp)
     }
 
     qemu_aio_context = aio_context_new(&local_error);
-    qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
     if (!qemu_aio_context) {
         error_propagate(errp, local_error);
         return -EMFILE;
     }
+    qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
     gpollfds = g_array_new(FALSE, FALSE, sizeof(GPollFD));
     src = aio_get_g_source(qemu_aio_context);
     g_source_attach(src, NULL);