| Message ID | 1466098418-26899-1-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
Acked-By: Artyom Tarasenko <atar4qemu@gmail.com> On Thu, Jun 16, 2016 at 7:33 PM, Thomas Huth <thuth@redhat.com> wrote: > There is no need to make sure that the memory is zeroed after the > allocation if we also immediatly fill the whole buffer afterwards > with memcpy(). Thus g_new0 should be g_new instead. But since we > are also doing a memcpy() here, we can also simply replace both > with g_memdup() instead. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > target-sparc/cpu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c > index 5b74cfc..7b43192 100644 > --- a/target-sparc/cpu.c > +++ b/target-sparc/cpu.c > @@ -115,8 +115,7 @@ static int cpu_sparc_register(SPARCCPU *cpu, const char *cpu_model) > return -1; > } > > - env->def = g_new0(sparc_def_t, 1); > - memcpy(env->def, def, sizeof(*def)); > + env->def = g_memdup(def, sizeof(*def)); > > featurestr = strtok(NULL, ","); > cc->parse_features(CPU(cpu), featurestr, &err); > -- > 1.8.3.1 >
16.06.2016 20:33, Thomas Huth wrote: > There is no need to make sure that the memory is zeroed after the > allocation if we also immediatly fill the whole buffer afterwards > with memcpy(). Thus g_new0 should be g_new instead. But since we > are also doing a memcpy() here, we can also simply replace both > with g_memdup() instead. Applied to -trivial, thanks! /mjt
diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index 5b74cfc..7b43192 100644 --- a/target-sparc/cpu.c +++ b/target-sparc/cpu.c @@ -115,8 +115,7 @@ static int cpu_sparc_register(SPARCCPU *cpu, const char *cpu_model) return -1; } - env->def = g_new0(sparc_def_t, 1); - memcpy(env->def, def, sizeof(*def)); + env->def = g_memdup(def, sizeof(*def)); featurestr = strtok(NULL, ","); cc->parse_features(CPU(cpu), featurestr, &err);
There is no need to make sure that the memory is zeroed after the allocation if we also immediatly fill the whole buffer afterwards with memcpy(). Thus g_new0 should be g_new instead. But since we are also doing a memcpy() here, we can also simply replace both with g_memdup() instead. Signed-off-by: Thomas Huth <thuth@redhat.com> --- target-sparc/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)