| Message ID | 1457502997-30904-3-git-send-email-peterx@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 03/08/2016 10:56 PM, Peter Xu wrote: > Using heap instead of stack for better safety. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > block/qapi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/block/qapi.c b/block/qapi.c > index c4c2115..b798e35 100644 > --- a/block/qapi.c > +++ b/block/qapi.c > @@ -636,9 +636,8 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, > for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) { > QType type = qobject_type(entry->value); > bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); > - char key[strlen(entry->key) + 1]; > + char *key = g_malloc(strlen(entry->key) + 1); > int i; > - > /* replace dashes with spaces in key (variable) names */ > for (i = 0; entry->key[i]; i++) { > key[i] = entry->key[i] == '-' ? ' ' : entry->key[i]; > @@ -650,6 +649,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, > if (!composite) { > func_fprintf(f, "\n"); > } > + g_free(key); > } > } > >
Peter Xu <peterx@redhat.com> writes: > Using heap instead of stack for better safety. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > block/qapi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/qapi.c b/block/qapi.c > index c4c2115..b798e35 100644 > --- a/block/qapi.c > +++ b/block/qapi.c > @@ -636,9 +636,8 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, > for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) { > QType type = qobject_type(entry->value); > bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); > - char key[strlen(entry->key) + 1]; > + char *key = g_malloc(strlen(entry->key) + 1); > int i; > - Unwanted whitespace change. > /* replace dashes with spaces in key (variable) names */ > for (i = 0; entry->key[i]; i++) { > key[i] = entry->key[i] == '-' ? ' ' : entry->key[i]; > @@ -650,6 +649,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, > if (!composite) { > func_fprintf(f, "\n"); > } > + g_free(key); > } > } With the unwanted whitespace change backed out: Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/block/qapi.c b/block/qapi.c index c4c2115..b798e35 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -636,9 +636,8 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) { QType type = qobject_type(entry->value); bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); - char key[strlen(entry->key) + 1]; + char *key = g_malloc(strlen(entry->key) + 1); int i; - /* replace dashes with spaces in key (variable) names */ for (i = 0; entry->key[i]; i++) { key[i] = entry->key[i] == '-' ? ' ' : entry->key[i]; @@ -650,6 +649,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, if (!composite) { func_fprintf(f, "\n"); } + g_free(key); } }
Using heap instead of stack for better safety. Signed-off-by: Peter Xu <peterx@redhat.com> --- block/qapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)