From patchwork Wed Feb 24 03:44:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Wang X-Patchwork-Id: 587176 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D590914076A for ; Wed, 24 Feb 2016 14:45:19 +1100 (AEDT) Received: from localhost ([::1]:33262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYQO6-0008Dm-07 for incoming@patchwork.ozlabs.org; Tue, 23 Feb 2016 22:45:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYQNp-0007oZ-UO for qemu-devel@nongnu.org; Tue, 23 Feb 2016 22:45:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYQNl-0006QD-U5 for qemu-devel@nongnu.org; Tue, 23 Feb 2016 22:45:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYQNl-0006Q9-Ok for qemu-devel@nongnu.org; Tue, 23 Feb 2016 22:44:57 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 4CDE57EBA1; Wed, 24 Feb 2016 03:44:57 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (vpn1-5-22.pek2.redhat.com [10.72.5.22]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1O3iqSg010784; Tue, 23 Feb 2016 22:44:54 -0500 From: Jason Wang To: jasowang@redhat.com, qemu-devel@nongnu.org Date: Wed, 24 Feb 2016 11:44:51 +0800 Message-Id: <1456285491-6952-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Yang Hongyang Subject: [Qemu-devel] [PATCH] net: filter: correctly remove filter from the list during finalization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Qemu may crash when we want to add two filters on the same netdev but the initialization of second fails (e.g missing parameters): ./qemu-system-x86_64 -netdev user,id=un0 \ -object filter-buffer,id=f0,netdev=un0,interval=10 \ -object filter-buffer,id=f1,netdev=un0 Segmentation fault (core dumped) This is because we don't check whether or not the filter was in the list of netdev. This patch fixes this. Cc: Yang Hongyang Signed-off-by: Jason Wang Reviewed-by: Yang Hongyang --- net/filter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/filter.c b/net/filter.c index d2a514e..7cdbc6c 100644 --- a/net/filter.c +++ b/net/filter.c @@ -196,7 +196,8 @@ static void netfilter_finalize(Object *obj) nfc->cleanup(nf); } - if (nf->netdev && !QTAILQ_EMPTY(&nf->netdev->filters)) { + if (nf->netdev && !QTAILQ_EMPTY(&nf->netdev->filters) && + nf->next.tqe_prev) { QTAILQ_REMOVE(&nf->netdev->filters, nf, next); } g_free(nf->netdev_id);