diff mbox

[PULL,6/6] MAINTAINERS: Add .travis.yml

Message ID 1454605920-12791-7-git-send-email-alex.bennee@linaro.org
State New
Headers show

Commit Message

Alex Bennée Feb. 4, 2016, 5:12 p.m. UTC
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

---
pr: added r-b tags
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Fam Zheng Feb. 5, 2016, 6:25 a.m. UTC | #1
On Thu, 02/04 17:12, Alex Bennée wrote:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> 
> ---
> pr: added r-b tags
> ---
>  MAINTAINERS | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b6ed87a..426a735 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1566,6 +1566,11 @@ L: qemu-block@nongnu.org
>  S: Supported
>  F: tests/image-fuzzer/
>  
> +Build and test automation
> +M: Alex Bennée <alex.bennee@linaro.org>
> +L: qemu-devel@nongnu.org
> +S: Supported
> +F: .travis.yml

Judging from the formatting, this section seems to fall in the "Block drivers"
category in the front. Maybe add a "---" line below the caption text,

    Build and test automation
    -------------------------
    M: ...
?

Can be a separate patch, though.

Fam
Alex Bennée Feb. 5, 2016, 4:26 p.m. UTC | #2
Fam Zheng <famz@redhat.com> writes:

> On Thu, 02/04 17:12, Alex Bennée wrote:
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>>
>> ---
>> pr: added r-b tags
>> ---
>>  MAINTAINERS | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b6ed87a..426a735 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1566,6 +1566,11 @@ L: qemu-block@nongnu.org
>>  S: Supported
>>  F: tests/image-fuzzer/
>>
>> +Build and test automation
>> +M: Alex Bennée <alex.bennee@linaro.org>
>> +L: qemu-devel@nongnu.org
>> +S: Supported
>> +F: .travis.yml
>
> Judging from the formatting, this section seems to fall in the "Block drivers"
> category in the front. Maybe add a "---" line below the caption text,
>
>     Build and test automation
>     -------------------------
>     M: ...
> ?
>
> Can be a separate patch, though.

As I've already submitted the pull I'll clean it up on the next round.

>
> Fam


--
Alex Bennée
Peter Maydell Feb. 5, 2016, 4:28 p.m. UTC | #3
On 5 February 2016 at 16:26, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Fam Zheng <famz@redhat.com> writes:
>> Can be a separate patch, though.
>
> As I've already submitted the pull I'll clean it up on the next round.

You told me this morning you were going to resubmit the pull
anyway, so you could fix it up if you wanted.

thanks
-- PMM
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index b6ed87a..426a735 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1566,6 +1566,11 @@  L: qemu-block@nongnu.org
 S: Supported
 F: tests/image-fuzzer/
 
+Build and test automation
+M: Alex Bennée <alex.bennee@linaro.org>
+L: qemu-devel@nongnu.org
+S: Supported
+F: .travis.yml
 
 Documentation
 -------------