From patchwork Thu Nov 12 22:55:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bandan Das X-Patchwork-Id: 543728 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2D7F714142D for ; Fri, 13 Nov 2015 09:57:56 +1100 (AEDT) Received: from localhost ([::1]:50169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx0oU-0007hW-9T for incoming@patchwork.ozlabs.org; Thu, 12 Nov 2015 17:57:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx0nB-0005e5-G3 for qemu-devel@nongnu.org; Thu, 12 Nov 2015 17:56:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx0nA-0007nn-Ji for qemu-devel@nongnu.org; Thu, 12 Nov 2015 17:56:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx0nA-0007nf-BU for qemu-devel@nongnu.org; Thu, 12 Nov 2015 17:56:32 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E92683B71A for ; Thu, 12 Nov 2015 22:56:31 +0000 (UTC) Received: from aqua.redhat.com (ovpn-113-187.phx2.redhat.com [10.3.113.187]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tACMuEZA013665; Thu, 12 Nov 2015 17:56:31 -0500 From: Bandan Das To: qemu-devel@nongnu.org Date: Thu, 12 Nov 2015 17:55:49 -0500 Message-Id: <1447368949-15312-3-git-send-email-bsd@redhat.com> In-Reply-To: <1447368949-15312-1-git-send-email-bsd@redhat.com> References: <1447368949-15312-1-git-send-email-bsd@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Bandan Das , armbru@redhat.com, mst@redhat.com Subject: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org There's no indication of any sort that i440fx doesn't support "iommu=on"" Signed-off-by: Bandan Das Reviewed-by: Eric Blake --- hw/pci-host/piix.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 7b2fbf9..ffcb846 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -34,6 +34,7 @@ #include "sysemu/sysemu.h" #include "hw/i386/ioapic.h" #include "qapi/visitor.h" +#include "qemu/error-report.h" /* * I440FX chipset data sheet. @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) static void i440fx_realize(PCIDevice *dev, Error **errp) { dev->config[I440FX_SMRAM] = 0x02; + + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { + error_report("warning: i440fx doesn't support emulated iommu\n"); + } } PCIBus *i440fx_init(const char *host_type, const char *pci_type,