diff mbox

object_new_with_type: remove redundant code

Message ID 1446700754-16219-1-git-send-email-caoj.fnst@cn.fujitsu.com
State New
Headers show

Commit Message

Cao jin Nov. 5, 2015, 5:19 a.m. UTC 
g_assert & type_initialize are called in object_initialize_with_type

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 qom/object.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Cao jin Nov. 5, 2015, 6:24 a.m. UTC | #1 
sorry for this, I am wrong at removing type_initialize.
please forget it

On 11/05/2015 01:19 PM, Cao jin wrote:
> g_assert & type_initialize are called in object_initialize_with_type
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>   qom/object.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index fc6e161..43ac2dd 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -423,9 +423,6 @@ Object *object_new_with_type(Type type)
>   {
>       Object *obj;
>
> -    g_assert(type != NULL);
> -    type_initialize(type);
> -
>       obj = g_malloc(type->instance_size);
>       object_initialize_with_type(obj, type->instance_size, type);
>       obj->free = g_free;
>
diff mbox

Patch

diff --git a/qom/object.c b/qom/object.c
index fc6e161..43ac2dd 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -423,9 +423,6 @@  Object *object_new_with_type(Type type)
 {
     Object *obj;
 
-    g_assert(type != NULL);
-    type_initialize(type);
-
     obj = g_malloc(type->instance_size);
     object_initialize_with_type(obj, type->instance_size, type);
     obj->free = g_free;