From patchwork Tue Oct 27 06:08:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Wang X-Patchwork-Id: 536454 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DAD1F1402CC for ; Tue, 27 Oct 2015 17:12:01 +1100 (AEDT) Received: from localhost ([::1]:57692 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqxUF-0007er-JH for incoming@patchwork.ozlabs.org; Tue, 27 Oct 2015 02:11:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqxS5-0003WR-MX for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqxS2-0000lR-F8 for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqxS2-0000lE-AB for qemu-devel@nongnu.org; Tue, 27 Oct 2015 02:09:42 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id E106EC0B5900; Tue, 27 Oct 2015 06:09:41 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (vpn1-5-148.pek2.redhat.com [10.72.5.148]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9R68v3i003000; Tue, 27 Oct 2015 02:09:38 -0400 From: Jason Wang To: peter.maydell@linaro.org, qemu-devel@nongnu.org Date: Tue, 27 Oct 2015 14:08:43 +0800 Message-Id: <1445926124-30681-10-git-send-email-jasowang@redhat.com> In-Reply-To: <1445926124-30681-1-git-send-email-jasowang@redhat.com> References: <1445926124-30681-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Paolo Bonzini , Jason Wang , Yang Hongyang Subject: [Qemu-devel] [PULL 09/10] net: make iov_to_buf take right size argument in nc_sendv_compat() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Yang Hongyang We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a pointer, which is wrong. Thanks to Paolo for pointing it out. Signed-off-by: Yang Hongyang Cc: Jason Wang Cc: Paolo Bonzini Signed-off-by: Jason Wang --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index 70a3576..2f2b39e 100644 --- a/net/net.c +++ b/net/net.c @@ -708,7 +708,7 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, offset = iov[0].iov_len; } else { buffer = buf; - offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer)); + offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); } if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) {