diff mbox

[04/11] trace: no need to call trace_backend_init in different branches now

Message ID 1445850626-29407-5-git-send-email-den@openvz.org
State New
Headers show

Commit Message

Denis V. Lunev Oct. 26, 2015, 9:10 a.m. UTC
original idea to split calling locations was to trace tracing thread
in the final child process according to

    commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad
    Author: Michael Mueller
    Date:   Mon Sep 23 16:36:54 2013 +0200

os_daemonize is now on top of both locations. Drop unneeded ifs.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 vl.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

Comments

Paolo Bonzini Oct. 26, 2015, 5:18 p.m. UTC | #1
On 26/10/2015 10:10, Denis V. Lunev wrote:
> original idea to split calling locations was to trace tracing thread
> in the final child process according to
> 
>     commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad
>     Author: Michael Mueller
>     Date:   Mon Sep 23 16:36:54 2013 +0200
> 
> os_daemonize is now on top of both locations. Drop unneeded ifs.

Oh, that's nice! :-)

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
>  vl.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index b1ddd3f..7ce9d70 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4083,10 +4083,8 @@ int main(int argc, char **argv, char **envp)
>          qemu_set_log(mask);
>      }
>  
> -    if (!is_daemonized()) {
> -        if (!trace_init_backends()) {
> -            exit(1);
> -        }
> +    if (!trace_init_backends()) {
> +        exit(1);
>      }
>  
>      /* If no data_dir is specified then try to find it relative to the
> @@ -4635,12 +4633,6 @@ int main(int argc, char **argv, char **envp)
>  
>      os_setup_post();
>  
> -    if (is_daemonized()) {
> -        if (!trace_init_backends()) {
> -            exit(1);
> -        }
> -    }
> -
>      main_loop();
>      bdrv_close_all();
>      pause_all_vcpus();
>
diff mbox

Patch

diff --git a/vl.c b/vl.c
index b1ddd3f..7ce9d70 100644
--- a/vl.c
+++ b/vl.c
@@ -4083,10 +4083,8 @@  int main(int argc, char **argv, char **envp)
         qemu_set_log(mask);
     }
 
-    if (!is_daemonized()) {
-        if (!trace_init_backends()) {
-            exit(1);
-        }
+    if (!trace_init_backends()) {
+        exit(1);
     }
 
     /* If no data_dir is specified then try to find it relative to the
@@ -4635,12 +4633,6 @@  int main(int argc, char **argv, char **envp)
 
     os_setup_post();
 
-    if (is_daemonized()) {
-        if (!trace_init_backends()) {
-            exit(1);
-        }
-    }
-
     main_loop();
     bdrv_close_all();
     pause_all_vcpus();