diff mbox

[01/11] trace: fix documentation

Message ID 1445850626-29407-2-git-send-email-den@openvz.org
State New
Headers show

Commit Message

Denis V. Lunev Oct. 26, 2015, 9:10 a.m. UTC 
From: Paolo Bonzini <pbonzini@redhat.com>

Mention the ftrace backend too.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 qemu-options.hx | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Christian Borntraeger Oct. 26, 2015, 8:05 p.m. UTC | #1 
Am 26.10.2015 um 18:10 schrieb Denis V. Lunev:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Mention the ftrace backend too.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>

Can you make that 
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
?

I agree with the series, but have not fully reviewed it
:-)

Christian
Denis V. Lunev Oct. 28, 2015, 3:15 p.m. UTC | #2 
On 10/26/2015 11:05 PM, Christian Borntraeger wrote:
> Am 26.10.2015 um 18:10 schrieb Denis V. Lunev:
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Mention the ftrace backend too.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Can you make that
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ?
>
> I agree with the series, but have not fully reviewed it
> :-)
>
> Christian
>
should I re-submit?

Den
Christian Borntraeger Oct. 29, 2015, 2:24 p.m. UTC | #3 
Am 28.10.2015 um 16:15 schrieb Denis V. Lunev:
> On 10/26/2015 11:05 PM, Christian Borntraeger wrote:
>> Am 26.10.2015 um 18:10 schrieb Denis V. Lunev:
>>> From: Paolo Bonzini <pbonzini@redhat.com>
>>>
>>> Mention the ftrace backend too.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Can you make that
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ?
>>
>> I agree with the series, but have not fully reviewed it
>> :-)
>>
>> Christian
>>
> should I re-submit?

Whoever commits this series can change it as well.
Stefan Hajnoczi Oct. 29, 2015, 5:18 p.m. UTC | #4 
On Wed, Oct 28, 2015 at 06:15:05PM +0300, Denis V. Lunev wrote:
> On 10/26/2015 11:05 PM, Christian Borntraeger wrote:
> >Am 26.10.2015 um 18:10 schrieb Denis V. Lunev:
> >>From: Paolo Bonzini <pbonzini@redhat.com>
> >>
> >>Mention the ftrace backend too.
> >>
> >>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>Signed-off-by: Denis V. Lunev <den@openvz.org>
> >>Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >Can you make that
> >Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >?
> >
> >I agree with the series, but have not fully reviewed it
> >:-)
> >
> >Christian
> >
> should I re-submit?

You don't need to re-submit for this change, it can be done when merging
the patch.
diff mbox

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index edee5f4..71296da 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3484,13 +3484,13 @@  Specify tracing options.
 @table @option
 @item events=@var{file}
 Immediately enable events listed in @var{file}.
-The file must contain one event name (as listed in the @var{trace-events} file)
-per line.
-This option is only available if QEMU has been compiled with
-either @var{simple} or @var{stderr} tracing backend.
+The file must contain one event name (as listed in the @file{trace-events} file)
+per line; globbing patterns are accepted too.  This option is only
+available if QEMU has been compiled with the @var{simple}, @var{stderr} or
+@var{ftrace} tracing backend.
+
 @item file=@var{file}
 Log output traces to @var{file}.
-
 This option is only available if QEMU has been compiled with
 the @var{simple} tracing backend.
 @end table