From patchwork Mon Oct 12 16:40:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 529205 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49C821402B0 for ; Tue, 13 Oct 2015 03:45:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=wdk5ceCN; dkim-atps=neutral Received: from localhost ([::1]:56628 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgE5-0002oz-VT for incoming@patchwork.ozlabs.org; Mon, 12 Oct 2015 12:45:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgBc-0006c5-HB for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:42:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlgBa-00019d-UW for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:42:56 -0400 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:33871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgBa-00019X-Om for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:42:54 -0400 Received: by padhy16 with SMTP id hy16so158190651pad.1 for ; Mon, 12 Oct 2015 09:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Nzn6qFWEYiQ2lFv/tT+H/jbi4OAZDnrkXYaP3aNXu+M=; b=wdk5ceCNBgGmJxpuFYRfc4zuq0uDAMdIux4qJ2mMiVZTfpYLPya50jtg5p6aFfUkG5 KuVd1F7Im9xZNG+QKRMRY4ubGVyVaM6MFGqeVMcG6Jzcdi5fhYD5OQzG9e2cRmpFbfCq CmJXYUOWzWTv7WZQ5L8LnL5AGkcZvHKCduegSMQIyumdvCVfOT5yL8g0LU+IbQ0gtNs/ P191J1IBrOEZz5X9R4JpiPe4ArhMzBsmtEjs+hywEadZMUPuWZmJ5aKRx55wkD7NrSyb EAw55D+sXpgyqnq8XgeZ+SBQ2GIijrQZLB9qGk9B50p1hEfj8nay/cbW/f6797iAAd+W rAyA== X-Received: by 10.68.192.99 with SMTP id hf3mr35909399pbc.66.1444668174359; Mon, 12 Oct 2015 09:42:54 -0700 (PDT) Received: from localhost (APoitiers-257-1-35-234.w90-38.abo.wanadoo.fr. [90.38.210.234]) by smtp.gmail.com with ESMTPSA id yq2sm19274971pbb.39.2015.10.12.09.42.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2015 09:42:53 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Mon, 12 Oct 2015 18:40:58 +0200 Message-Id: <1444668104-22955-5-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> References: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::230 Cc: peter.maydell@linaro.org, drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PULL v2 04/50] ivhsmem: read do not accept more than sizeof(long) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau ivshmem_read() only reads sizeof(long) from the input buffer. Accepting more could lead to fifo8 abort() on 32bit systems if fifo is not empty. A following patch will change the protocol to 64-bit little-endian instead. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index cc76989..fb53b3f 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -272,7 +272,7 @@ static void ivshmem_receive(void *opaque, const uint8_t *buf, int size) static int ivshmem_can_receive(void * opaque) { - return 8; + return sizeof(long); } static void ivshmem_event(void *opaque, int event)