From patchwork Mon Oct 12 16:41:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 529213 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9629E1402B2 for ; Tue, 13 Oct 2015 03:50:31 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=H6fQsqxF; dkim-atps=neutral Received: from localhost ([::1]:56671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgIv-00028U-GA for incoming@patchwork.ozlabs.org; Mon, 12 Oct 2015 12:50:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgEw-00049h-ER for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:46:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlgEs-00024r-EO for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:46:22 -0400 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:34184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgEs-00024e-9S for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:46:18 -0400 Received: by padhy16 with SMTP id hy16so158255612pad.1 for ; Mon, 12 Oct 2015 09:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Fv4pmU1872Hh93XwijvQcLrNa46/n/d4AlNaO6TlzjM=; b=H6fQsqxFF0hLsWg5M4Q59HXDET/je1L4RqQD64fbi3TD57ECbriFdLJjPlIZKWhGyE jARGQotzrRaWpbWyE+k6h6F/BHFiLZpQXNWKghmDonmVQ/8BYWXg8rq+UQo4vAnEZNyj fldsw5Pum0uyqtaA/nPMbb2foW5t2LIk5Sv/+0m8FzCtHh8SIZ0jDtPIzG4d432gKtUe AtmG9KmOWbsyaDEsfTb2wZrcXNVp/wFhNkAkaajRGLJy4xX/cRdgufs7IojpmELP5HCu zQc3oy6cnrWMlKdwYoNdFgd0kaV6tSwA72Nox7TuMwPvLExhyFqDde2QG1l1B4Cf6TAh C9Pw== X-Received: by 10.66.147.104 with SMTP id tj8mr35123736pab.125.1444668377852; Mon, 12 Oct 2015 09:46:17 -0700 (PDT) Received: from localhost (APoitiers-257-1-35-234.w90-38.abo.wanadoo.fr. [90.38.210.234]) by smtp.gmail.com with ESMTPSA id ce3sm19291876pbb.35.2015.10.12.09.46.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2015 09:46:16 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Mon, 12 Oct 2015 18:41:12 +0200 Message-Id: <1444668104-22955-19-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> References: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::229 Cc: peter.maydell@linaro.org, drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PULL v2 18/50] ivshmem: improve debug messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau Some misc improvements to ivshmem debug. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index c4c130d..50f9c8f 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -208,10 +208,13 @@ static void ivshmem_io_write(void *opaque, hwaddr addr, if (vector < s->peers[dest].nb_eventfds) { IVSHMEM_DPRINTF("Notifying VM %d on vector %d\n", dest, vector); event_notifier_set(&s->peers[dest].eventfds[vector]); + } else { + IVSHMEM_DPRINTF("Invalid destination vector %d on VM %d\n", + vector, dest); } break; default: - IVSHMEM_DPRINTF("Invalid VM Doorbell VM %d\n", dest); + IVSHMEM_DPRINTF("Unhandled write " TARGET_FMT_plx "\n", addr); } } @@ -263,9 +266,9 @@ static void ivshmem_receive(void *opaque, const uint8_t *buf, int size) { IVShmemState *s = opaque; - ivshmem_IntrStatus_write(s, *buf); + IVSHMEM_DPRINTF("ivshmem_receive 0x%02x size: %d\n", *buf, size); - IVSHMEM_DPRINTF("ivshmem_receive 0x%02x\n", *buf); + ivshmem_IntrStatus_write(s, *buf); } static int ivshmem_can_receive(void * opaque) @@ -592,6 +595,7 @@ static void ivshmem_use_msix(IVShmemState * s) PCIDevice *d = PCI_DEVICE(s); int i; + IVSHMEM_DPRINTF("%s, msix present: %d\n", __func__, msix_present(d)); if (!msix_present(d)) { return; }