From patchwork Mon Oct 12 16:41:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 529216 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B2F411402B2 for ; Tue, 13 Oct 2015 03:52:14 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=IdiNATHZ; dkim-atps=neutral Received: from localhost ([::1]:56689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgKZ-0004WB-3G for incoming@patchwork.ozlabs.org; Mon, 12 Oct 2015 12:52:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgDX-0001l5-7N for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:44:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlgDU-0001Ye-1q for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:44:55 -0400 Received: from mail-pa0-x236.google.com ([2607:f8b0:400e:c03::236]:32840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgDT-0001YD-Tl for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:44:52 -0400 Received: by pabrc13 with SMTP id rc13so23405034pab.0 for ; Mon, 12 Oct 2015 09:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ePhXzt6Y9HxHzQDXC6UDmGPEMNI0JeLAMYb7e0fywlc=; b=IdiNATHZgaRjJnYmy0JrnTOoZTZ1XQMpIAoEGzG/QIwoKIuF/UQfZE6075E5FzBs/Q ugjreAim+mM1RV3Krz2cliOUCwYa1OSUxl6l/p26UlNS19CxOg+UBVvn/A7QGVoi4Hek RmuFhcd1sDMUrRxmUoOt3QC+bwThasKXu0GECr3pIzaPpD7hH5Fcrzp0xOzZoAtXfFm8 uj3vgc2jpMsSZvOuUS8sd89rXnpAv9JUe1pGIKaMaAq9Qn2fo2ooc6s6vPrbdbqBieY9 NPzLnirzwa33HT47Y52fa4BUtWB5dJNE0zqBOveJACzzzAvcvLNED//YJbprSV3a/pQG UGag== X-Received: by 10.68.211.68 with SMTP id na4mr34909480pbc.94.1444668291564; Mon, 12 Oct 2015 09:44:51 -0700 (PDT) Received: from localhost (APoitiers-257-1-35-234.w90-38.abo.wanadoo.fr. [90.38.210.234]) by smtp.gmail.com with ESMTPSA id ai4sm3349310pbc.67.2015.10.12.09.44.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2015 09:44:50 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Mon, 12 Oct 2015 18:41:05 +0200 Message-Id: <1444668104-22955-12-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> References: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::236 Cc: peter.maydell@linaro.org, drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PULL v2 11/50] ivshmem: remove last exit(1) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau Failing to create a chardev shouldn't be fatal. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 62547c0..e7224b9 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -299,7 +299,7 @@ static CharDriverState* create_eventfd_chr_device(void * opaque, EventNotifier * if (chr == NULL) { error_report("creating eventfd for eventfd %d failed", eventfd); - exit(1); + return NULL; } qemu_chr_fe_claim_no_fail(chr);