From patchwork Tue Oct 6 19:19:13 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 526944 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:4830:134:3::10]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 87820140D71 for ; Wed, 7 Oct 2015 06:32:56 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=UVTEXJew; dkim-atps=neutral Received: from lists.gnu.org ([208.118.235.17]:38812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjXyn-0000WN-Vi for incoming@patchwork.ozlabs.org; Tue, 06 Oct 2015 15:32:54 -0400 Received: from localhost ([::1]:53397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjXyn-0001JP-TJ for incoming@patchwork.ozlabs.org; Tue, 06 Oct 2015 15:32:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjXo4-0001Rk-Gx for qemu-devel@nongnu.org; Tue, 06 Oct 2015 15:22:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjXnB-0004Jk-NO for qemu-devel@nongnu.org; Tue, 06 Oct 2015 15:21:48 -0400 Received: from mail-qg0-x22b.google.com ([2607:f8b0:400d:c04::22b]:35095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjXnA-0004GS-JZ for qemu-devel@nongnu.org; Tue, 06 Oct 2015 15:20:53 -0400 Received: by qgt47 with SMTP id 47so183759982qgt.2 for ; Tue, 06 Oct 2015 12:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Fv4pmU1872Hh93XwijvQcLrNa46/n/d4AlNaO6TlzjM=; b=UVTEXJewzjIzqXcbEyKijhaSBnc24ytaV37Uk2cFYu2SQYGSY+NoG8WmjmV3SxYd/O qnvgElxcK26e1Y5+sgfaFnR2P/qvH+8utsxSFJALO5t4PLarO0fIM+I8y8YT4wdOCpnq if5ylVA7Ly8B5E6544PH4H0ikrvhz3QjiLpg21LxvkFOlkdmAbKUU1aCQGFaI1psNImj +72yqDPFn1mDxqG6Rp424n9z+v1GKShOnNdMdvneimsXXkp6dd72RHynOpe3t6DVMTcP TCFItMP1e4w60CyzAyF5qx0NebVFqdFt1vxpTe0E+v4DrZoz/QiGyaTnh9OjpUVdnW/s 6Ztw== X-Received: by 10.140.235.210 with SMTP id g201mr51785292qhc.89.1444159252075; Tue, 06 Oct 2015 12:20:52 -0700 (PDT) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by smtp.gmail.com with ESMTPSA id 84sm4966653qkz.8.2015.10.06.12.20.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2015 12:20:51 -0700 (PDT) From: marcandre.lureau@redhat.com To: peter.maydell@linaro.org Date: Tue, 6 Oct 2015 21:19:13 +0200 Message-Id: <1444159184-18153-18-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1444159184-18153-1-git-send-email-marcandre.lureau@redhat.com> References: <1444159184-18153-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c04::22b Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Subject: [Qemu-devel] [PULL 17/48] ivshmem: improve debug messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x From: Marc-André Lureau Some misc improvements to ivshmem debug. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index c4c130d..50f9c8f 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -208,10 +208,13 @@ static void ivshmem_io_write(void *opaque, hwaddr addr, if (vector < s->peers[dest].nb_eventfds) { IVSHMEM_DPRINTF("Notifying VM %d on vector %d\n", dest, vector); event_notifier_set(&s->peers[dest].eventfds[vector]); + } else { + IVSHMEM_DPRINTF("Invalid destination vector %d on VM %d\n", + vector, dest); } break; default: - IVSHMEM_DPRINTF("Invalid VM Doorbell VM %d\n", dest); + IVSHMEM_DPRINTF("Unhandled write " TARGET_FMT_plx "\n", addr); } } @@ -263,9 +266,9 @@ static void ivshmem_receive(void *opaque, const uint8_t *buf, int size) { IVShmemState *s = opaque; - ivshmem_IntrStatus_write(s, *buf); + IVSHMEM_DPRINTF("ivshmem_receive 0x%02x size: %d\n", *buf, size); - IVSHMEM_DPRINTF("ivshmem_receive 0x%02x\n", *buf); + ivshmem_IntrStatus_write(s, *buf); } static int ivshmem_can_receive(void * opaque) @@ -592,6 +595,7 @@ static void ivshmem_use_msix(IVShmemState * s) PCIDevice *d = PCI_DEVICE(s); int i; + IVSHMEM_DPRINTF("%s, msix present: %d\n", __func__, msix_present(d)); if (!msix_present(d)) { return; }