From patchwork Fri Oct 2 19:09:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 525728 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 011BE1402D5 for ; Sat, 3 Oct 2015 05:23:22 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=rWHsgC1o; dkim-atps=neutral Received: from localhost ([::1]:34579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi5vL-0006wq-Gk for incoming@patchwork.ozlabs.org; Fri, 02 Oct 2015 15:23:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi5iW-0007Pb-Sz for qemu-devel@nongnu.org; Fri, 02 Oct 2015 15:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi5iT-0006lC-2u for qemu-devel@nongnu.org; Fri, 02 Oct 2015 15:10:04 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:36180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi5iS-0006kf-SR for qemu-devel@nongnu.org; Fri, 02 Oct 2015 15:10:00 -0400 Received: by wicgb1 with SMTP id gb1so45842861wic.1 for ; Fri, 02 Oct 2015 12:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Nzn6qFWEYiQ2lFv/tT+H/jbi4OAZDnrkXYaP3aNXu+M=; b=rWHsgC1onPaUcS9a3D2OVKrVdZ0u68ZdZDN+EuShmw0PS2YJ44GOOE8cfLwhIqeg3Q 1bY1eJ7UB7dzoMeW0dwFwUfD5GEIL2O3IX+tyPkDraAl+U4gBv/QCq7683QR7jiRWaog mFe3aSot0GQr42FpY2hy6snByAkarKe1h+6UITY9oPKRicYpegkChXB59/aeJvM4VyyY 2q/jzCBk+E9VUAweXKvo8dhqXMjkgCa0ZPuGOF3ryYQx6ROhuehwg6D6NIpt2N1sg1yq cxVhEo5uBg1PHjbrJLRtt0TdP1GIdK859qGKOAhuUo/ghd0/+58LW1Nlz0G8eS9wo7tY 8y1A== X-Received: by 10.194.184.136 with SMTP id eu8mr20150886wjc.151.1443813000300; Fri, 02 Oct 2015 12:10:00 -0700 (PDT) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by smtp.gmail.com with ESMTPSA id gh9sm12709894wjb.27.2015.10.02.12.09.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Oct 2015 12:09:59 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Fri, 2 Oct 2015 21:09:06 +0200 Message-Id: <1443812991-17356-4-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1443812991-17356-1-git-send-email-marcandre.lureau@redhat.com> References: <1443812991-17356-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22a Cc: drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PATCH v5 03/48] ivhsmem: read do not accept more than sizeof(long) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau ivshmem_read() only reads sizeof(long) from the input buffer. Accepting more could lead to fifo8 abort() on 32bit systems if fifo is not empty. A following patch will change the protocol to 64-bit little-endian instead. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index cc76989..fb53b3f 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -272,7 +272,7 @@ static void ivshmem_receive(void *opaque, const uint8_t *buf, int size) static int ivshmem_can_receive(void * opaque) { - return 8; + return sizeof(long); } static void ivshmem_event(void *opaque, int event)