From patchwork Thu Sep 24 11:37:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 522245 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 303F3140271 for ; Thu, 24 Sep 2015 21:45:20 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Yk3ibPLF; dkim-atps=neutral Received: from localhost ([::1]:58029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf4xi-0002VR-9t for incoming@patchwork.ozlabs.org; Thu, 24 Sep 2015 07:45:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf4r8-0007P4-LF for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:38:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zf4r7-0006h8-Og for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:38:30 -0400 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]:32819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf4r7-0006gm-Lk for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:38:29 -0400 Received: by qkdw123 with SMTP id w123so28220415qkd.0 for ; Thu, 24 Sep 2015 04:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=hCIKG6C1/UYzI6FdVRMWbvRuRVDCZE7Dr/PVSeXirNg=; b=Yk3ibPLFxCxopbuGgy3rRMUR5ddPcZnD3/uii5AqLWUwjMGHmDrgL9RebfUiK77A2C 5WUw1IwEzB+Fe8Q9K4hvEfpIvLHw6Mlm/B1byE4cgPLMT72ptsalsznrOHvzt6ZNxzqX 5LMqf+Ucqc4S3+owAIMVqexruC4KA1pOeMP1YR/ru3tHWenjuGihkPVZs77Cf7x6aTLo cOC8YN0+XKKwj3aldMiqzJR5RE6nC8Zb0Xq91uQRJcBtQQVvLe2qQRie1koUkNq7IUk1 Jg6l4imkRiv53DGxRdlxWCnx73xtpWzxgqFD9bK7uAFDGuIillqGX6uFEXlUmpd1MQgj Bcmw== X-Received: by 10.55.192.130 with SMTP id v2mr41820100qkv.82.1443094709400; Thu, 24 Sep 2015 04:38:29 -0700 (PDT) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by smtp.gmail.com with ESMTPSA id n17sm4280820qhb.29.2015.09.24.04.38.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Sep 2015 04:38:28 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Thu, 24 Sep 2015 13:37:16 +0200 Message-Id: <1443094669-4144-15-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> References: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c09::230 Cc: drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PATCH v4 14/47] ivshmem: remove useless ivshmem_update_irq() val argument X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau val isn't used in ivshmem_update_irq() function. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 19640bb..374ecff 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -123,7 +123,7 @@ static inline bool is_power_of_two(uint64_t x) { } /* accessing registers - based on rtl8139 */ -static void ivshmem_update_irq(IVShmemState *s, int val) +static void ivshmem_update_irq(IVShmemState *s) { PCIDevice *d = PCI_DEVICE(s); int isr; @@ -144,7 +144,7 @@ static void ivshmem_IntrMask_write(IVShmemState *s, uint32_t val) s->intrmask = val; - ivshmem_update_irq(s, val); + ivshmem_update_irq(s); } static uint32_t ivshmem_IntrMask_read(IVShmemState *s) @@ -162,7 +162,7 @@ static void ivshmem_IntrStatus_write(IVShmemState *s, uint32_t val) s->intrstatus = val; - ivshmem_update_irq(s, val); + ivshmem_update_irq(s); } static uint32_t ivshmem_IntrStatus_read(IVShmemState *s) @@ -172,7 +172,7 @@ static uint32_t ivshmem_IntrStatus_read(IVShmemState *s) /* reading ISR clears all interrupts */ s->intrstatus = 0; - ivshmem_update_irq(s, 0); + ivshmem_update_irq(s); return ret; }