| Message ID | 1441719672-25296-1-git-send-email-nathan@nathanrossi.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Sep 08, 2015 at 11:41:12PM +1000, Nathan Rossi wrote: > The GIC in ZynqMP cover a 64K address space, however the actual > registers are decoded within a 4K address space and mirrored at the 4K > boundaries. This change fixes the defined size for these regions as it > was set to 0x4000/16K incorrectly. > > Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Adding Alistair, Crosthwaite and Maydell. Thanks Nathan! Edgar > --- > include/hw/arm/xlnx-zynqmp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h > index 6ccb57b..23b8453 100644 > --- a/include/hw/arm/xlnx-zynqmp.h > +++ b/include/hw/arm/xlnx-zynqmp.h > @@ -44,7 +44,7 @@ > * number of memory region aliases. > */ > > -#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x4000 > +#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x1000 > #define XLNX_ZYNQMP_GIC_ALIASES (0x10000 / XLNX_ZYNQMP_GIC_REGION_SIZE - 1) > > typedef struct XlnxZynqMPState { > -- > 2.5.1 >
On 8 September 2015 at 14:41, Nathan Rossi <nathan@nathanrossi.com> wrote: > The GIC in ZynqMP cover a 64K address space, however the actual > registers are decoded within a 4K address space and mirrored at the 4K > boundaries. This change fixes the defined size for these regions as it > was set to 0x4000/16K incorrectly. > > Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> > --- > include/hw/arm/xlnx-zynqmp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h > index 6ccb57b..23b8453 100644 > --- a/include/hw/arm/xlnx-zynqmp.h > +++ b/include/hw/arm/xlnx-zynqmp.h > @@ -44,7 +44,7 @@ > * number of memory region aliases. > */ > > -#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x4000 > +#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x1000 > #define XLNX_ZYNQMP_GIC_ALIASES (0x10000 / XLNX_ZYNQMP_GIC_REGION_SIZE - 1) > > typedef struct XlnxZynqMPState { Applied to target-arm.next, thanks. -- PMM
diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h index 6ccb57b..23b8453 100644 --- a/include/hw/arm/xlnx-zynqmp.h +++ b/include/hw/arm/xlnx-zynqmp.h @@ -44,7 +44,7 @@ * number of memory region aliases. */ -#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x4000 +#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x1000 #define XLNX_ZYNQMP_GIC_ALIASES (0x10000 / XLNX_ZYNQMP_GIC_REGION_SIZE - 1) typedef struct XlnxZynqMPState {
The GIC in ZynqMP cover a 64K address space, however the actual registers are decoded within a 4K address space and mirrored at the 4K boundaries. This change fixes the defined size for these regions as it was set to 0x4000/16K incorrectly. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> --- include/hw/arm/xlnx-zynqmp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)