| Message ID | 1436383152-18033-2-git-send-email-konrad.wilk@oracle.com |
|---|---|
| State | New |
| Headers | show |
On Wed, 8 Jul 2015, Konrad Rzeszutek Wilk wrote: > Instead we have the emulation registers ->init functions which > consult the host values to see what the initial value should be > and they are responsible for populating the dev.config. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > hw/xen/xen_pt.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 05828e0..cd69cb4 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -780,12 +780,7 @@ static int xen_pt_initfn(PCIDevice *d) > } > > /* Initialize virtualized PCI configuration (Extended 256 Bytes) */ > - rc = xen_host_pci_get_block(&s->real_device, 0, d->config, > - PCI_CONFIG_SPACE_SIZE); > - if (rc < 0) { > - XEN_PT_ERR(d,"Could not read PCI_CONFIG space! (rc:%d)\n", rc); > - goto err_out; > - } > + memset(d->config, 0, PCI_CONFIG_SPACE_SIZE); > > s->memory_listener = xen_pt_memory_listener; > s->io_listener = xen_pt_io_listener;
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 05828e0..cd69cb4 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -780,12 +780,7 @@ static int xen_pt_initfn(PCIDevice *d) } /* Initialize virtualized PCI configuration (Extended 256 Bytes) */ - rc = xen_host_pci_get_block(&s->real_device, 0, d->config, - PCI_CONFIG_SPACE_SIZE); - if (rc < 0) { - XEN_PT_ERR(d,"Could not read PCI_CONFIG space! (rc:%d)\n", rc); - goto err_out; - } + memset(d->config, 0, PCI_CONFIG_SPACE_SIZE); s->memory_listener = xen_pt_memory_listener; s->io_listener = xen_pt_io_listener;
Instead we have the emulation registers ->init functions which consult the host values to see what the initial value should be and they are responsible for populating the dev.config. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- hw/xen/xen_pt.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)