From patchwork Tue Jul 7 15:52:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 492384 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 847621402C8 for ; Wed, 8 Jul 2015 02:14:11 +1000 (AEST) Received: from localhost ([::1]:59303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCVVZ-0003Or-MG for incoming@patchwork.ozlabs.org; Tue, 07 Jul 2015 12:14:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCVAq-0001Gg-P0 for qemu-devel@nongnu.org; Tue, 07 Jul 2015 11:52:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCVAp-0005DZ-8h for qemu-devel@nongnu.org; Tue, 07 Jul 2015 11:52:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44691 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCVAp-0005DJ-3L for qemu-devel@nongnu.org; Tue, 07 Jul 2015 11:52:43 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 80873AC6A; Tue, 7 Jul 2015 15:52:42 +0000 (UTC) From: Alexander Graf To: qemu-devel@nongnu.org Date: Tue, 7 Jul 2015 17:52:39 +0200 Message-Id: <1436284361-5745-3-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1436284361-5745-1-git-send-email-agraf@suse.de> References: <1436284361-5745-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 Cc: peter.maydell@linaro.org, Aurelien Jarno Subject: [Qemu-devel] [PULL 2/4] target-s390x: fix EXECUTE instruction executing TRT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Aurelien Jarno A break is missing in the EXECUTE instruction, when executing the TRANSLATE AND TEST instruction. Reported-by: Paolo Bonzini Signed-off-by: Aurelien Jarno Reviewed-By: Richard Henderson Signed-off-by: Alexander Graf --- target-s390x/mem_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c index 9f0eb1e..6f8bd79 100644 --- a/target-s390x/mem_helper.c +++ b/target-s390x/mem_helper.c @@ -482,6 +482,7 @@ uint32_t HELPER(ex)(CPUS390XState *env, uint32_t cc, uint64_t v1, case 0xc00: helper_tr(env, l, get_address(env, 0, b1, d1), get_address(env, 0, b2, d2)); + break; case 0xd00: cc = helper_trt(env, l, get_address(env, 0, b1, d1), get_address(env, 0, b2, d2));