Message ID | 1435865479-18329-6-git-send-email-konrad.wilk@oracle.com |
---|---|
State | New |
Headers | show |
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > We would like to know what the MSI register value is to help > in troubleshooting in the field. As such modify the logging > logic to include such details in xen_pt_msgctrl_reg_write. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > hw/xen/xen_pt_config_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c > index dd37be3..462e1b9 100644 > --- a/hw/xen/xen_pt_config_init.c > +++ b/hw/xen/xen_pt_config_init.c > @@ -1086,7 +1086,7 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s, > /* setup MSI pirq for the first time */ > if (!msi->initialized) { > /* Init physical one */ > - XEN_PT_LOG(&s->dev, "setup MSI\n"); > + XEN_PT_LOG(&s->dev, "setup MSI (register: %x).\n", *val); > if (xen_pt_msi_setup(s)) { > /* We do not broadcast the error to the framework code, so > * that MSI errors are contained in MSI emulation code and > @@ -1094,12 +1094,12 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s, > * Guest MSI would be actually not working. > */ > *val &= ~PCI_MSI_FLAGS_ENABLE; > - XEN_PT_WARN(&s->dev, "Can not map MSI.\n"); > + XEN_PT_WARN(&s->dev, "Can not map MSI (register: %x)!\n", *val); > return 0; > } > if (xen_pt_msi_update(s)) { > *val &= ~PCI_MSI_FLAGS_ENABLE; > - XEN_PT_WARN(&s->dev, "Can not bind MSI\n"); > + XEN_PT_WARN(&s->dev, "Can not bind MSI (register: %x)!\n", *val); > return 0; > } > msi->initialized = true; > -- > 2.1.0 >
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index dd37be3..462e1b9 100644 --- a/hw/xen/xen_pt_config_init.c +++ b/hw/xen/xen_pt_config_init.c @@ -1086,7 +1086,7 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s, /* setup MSI pirq for the first time */ if (!msi->initialized) { /* Init physical one */ - XEN_PT_LOG(&s->dev, "setup MSI\n"); + XEN_PT_LOG(&s->dev, "setup MSI (register: %x).\n", *val); if (xen_pt_msi_setup(s)) { /* We do not broadcast the error to the framework code, so * that MSI errors are contained in MSI emulation code and @@ -1094,12 +1094,12 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s, * Guest MSI would be actually not working. */ *val &= ~PCI_MSI_FLAGS_ENABLE; - XEN_PT_WARN(&s->dev, "Can not map MSI.\n"); + XEN_PT_WARN(&s->dev, "Can not map MSI (register: %x)!\n", *val); return 0; } if (xen_pt_msi_update(s)) { *val &= ~PCI_MSI_FLAGS_ENABLE; - XEN_PT_WARN(&s->dev, "Can not bind MSI\n"); + XEN_PT_WARN(&s->dev, "Can not bind MSI (register: %x)!\n", *val); return 0; } msi->initialized = true;
We would like to know what the MSI register value is to help in troubleshooting in the field. As such modify the logging logic to include such details in xen_pt_msgctrl_reg_write. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- hw/xen/xen_pt_config_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)