diff mbox

target-s390x: fix EXECUTE instruction executing TRT

Message ID 1434905468-31873-1-git-send-email-aurelien@aurel32.net
State New
Headers show

Commit Message

Aurelien Jarno June 21, 2015, 4:51 p.m. UTC 
A break is missing in the EXECUTE instruction, when executing the
TRANSLATE AND TEST instruction.

Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Cc: Alexander Graf <agraf@suse.de>
Cc: Richard Henderson <rth@twiddle.net>
---
 target-s390x/mem_helper.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Richard Henderson June 29, 2015, 9:15 a.m. UTC | #1 
On 06/21/2015 05:51 PM, Aurelien Jarno wrote:
> A break is missing in the EXECUTE instruction, when executing the
> TRANSLATE AND TEST instruction.
>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Richard Henderson <rth@twiddle.net>

Reviewed-By: Richard Henderson <rth@twiddle.net>


r~
Alexander Graf June 29, 2015, 11:45 a.m. UTC | #2 
On 06/29/15 11:15, Richard Henderson wrote:
> On 06/21/2015 05:51 PM, Aurelien Jarno wrote:
>> A break is missing in the EXECUTE instruction, when executing the
>> TRANSLATE AND TEST instruction.
>>
>> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>> Cc: Alexander Graf <agraf@suse.de>
>> Cc: Richard Henderson <rth@twiddle.net>
>
> Reviewed-By: Richard Henderson <rth@twiddle.net>

Thanks, applied to s390-next.


Alex
diff mbox

Patch

diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c
index 9f0eb1e..6f8bd79 100644
--- a/target-s390x/mem_helper.c
+++ b/target-s390x/mem_helper.c
@@ -482,6 +482,7 @@  uint32_t HELPER(ex)(CPUS390XState *env, uint32_t cc, uint64_t v1,
         case 0xc00:
             helper_tr(env, l, get_address(env, 0, b1, d1),
                       get_address(env, 0, b2, d2));
+            break;
         case 0xd00:
             cc = helper_trt(env, l, get_address(env, 0, b1, d1),
                             get_address(env, 0, b2, d2));