From patchwork Thu Jun 11 09:38:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frediano Ziglio X-Patchwork-Id: 483138 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 93D62140290 for ; Thu, 11 Jun 2015 23:05:41 +1000 (AEST) Received: from localhost ([::1]:46559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z32At-0000r6-MC for incoming@patchwork.ozlabs.org; Thu, 11 Jun 2015 09:05:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2ywT-0004WM-OM for qemu-devel@nongnu.org; Thu, 11 Jun 2015 05:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2ywQ-0008Bc-Hw for qemu-devel@nongnu.org; Thu, 11 Jun 2015 05:38:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2ywQ-0008BH-Ar for qemu-devel@nongnu.org; Thu, 11 Jun 2015 05:38:30 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 98478BBB4F; Thu, 11 Jun 2015 09:38:29 +0000 (UTC) Received: from rhwork.redhat.com (vpn1-7-151.ams2.redhat.com [10.36.7.151]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5B9cRNU000835; Thu, 11 Jun 2015 05:38:28 -0400 From: Frediano Ziglio To: fziglio@redhat.com, Gerd Hoffmann , spice-devel@lists.freedesktop.org Date: Thu, 11 Jun 2015 10:38:26 +0100 Message-Id: <1434015506-6955-1-git-send-email-fziglio@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-Mailman-Approved-At: Thu, 11 Jun 2015 09:01:29 -0400 Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH v2] RFC: qxl: allow to specify head limit to qxl driver X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch allow to limit number of heads using qxl driver. By default qxl driver is not limited on any kind on head use so can decide to use as much heads. libvirt has this as a video card parameter (actually set to 1 but not used). This parameter will allow to limit setting a use can do (which could be confusing). This patch rely on some change in spice-protocol which are not still accepted. See http://lists.freedesktop.org/archives/spice-devel/2015-June/020221.html. Signed-off-by: Frediano Ziglio --- hw/display/qxl.c | 20 +++++++++++++++----- hw/display/qxl.h | 1 + 2 files changed, 16 insertions(+), 5 deletions(-) This version change the way limit is set. It came from Gerd Hoffmann suggestion. diff --git a/hw/display/qxl.c b/hw/display/qxl.c index b220e2d..678fde5 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -272,6 +272,10 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay) QXL_COOKIE_TYPE_POST_LOAD_MONITORS_CONFIG, 0)); } else { + if (qxl->max_outputs) { + spice_qxl_set_monitors_config_limit(&qxl->ssd.qxl, + qxl->max_outputs); + } qxl->guest_monitors_config = qxl->ram->monitors_config; spice_qxl_monitors_config_async(&qxl->ssd.qxl, qxl->ram->monitors_config, @@ -992,6 +996,7 @@ static int interface_client_monitors_config(QXLInstance *sin, PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl); QXLRom *rom = memory_region_get_ram_ptr(&qxl->rom_bar); int i; + unsigned max_outputs = ARRAY_SIZE(rom->client_monitors_config.heads); if (qxl->revision < 4) { trace_qxl_client_monitors_config_unsupported_by_device(qxl->id, @@ -1014,17 +1019,21 @@ static int interface_client_monitors_config(QXLInstance *sin, if (!monitors_config) { return 1; } + + /* limit number of outputs based on setting limit */ + if (qxl->max_outputs && qxl->max_outputs <= max_outputs) { + max_outputs = qxl->max_outputs; + } + memset(&rom->client_monitors_config, 0, sizeof(rom->client_monitors_config)); rom->client_monitors_config.count = monitors_config->num_of_monitors; /* monitors_config->flags ignored */ - if (rom->client_monitors_config.count >= - ARRAY_SIZE(rom->client_monitors_config.heads)) { + if (rom->client_monitors_config.count >= max_outputs) { trace_qxl_client_monitors_config_capped(qxl->id, monitors_config->num_of_monitors, - ARRAY_SIZE(rom->client_monitors_config.heads)); - rom->client_monitors_config.count = - ARRAY_SIZE(rom->client_monitors_config.heads); + max_outputs); + rom->client_monitors_config.count = max_outputs; } for (i = 0 ; i < rom->client_monitors_config.count ; ++i) { VDAgentMonConfig *monitor = &monitors_config->monitors[i]; @@ -2278,6 +2287,7 @@ static Property qxl_properties[] = { DEFINE_PROP_UINT32("vram64_size_mb", PCIQXLDevice, vram_size_mb, -1), DEFINE_PROP_UINT32("vgamem_mb", PCIQXLDevice, vgamem_size_mb, 16), DEFINE_PROP_INT32("surfaces", PCIQXLDevice, ssd.num_surfaces, 1024), + DEFINE_PROP_UINT16("max_outputs", PCIQXLDevice, max_outputs, 0), DEFINE_PROP_END_OF_LIST(), }; diff --git a/hw/display/qxl.h b/hw/display/qxl.h index deddd54..d045f59 100644 --- a/hw/display/qxl.h +++ b/hw/display/qxl.h @@ -99,6 +99,7 @@ typedef struct PCIQXLDevice { QXLModes *modes; uint32_t rom_size; MemoryRegion rom_bar; + uint16_t max_outputs; /* vram pci bar */ uint32_t vram_size;