From patchwork Mon Jun 8 16:47:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kashyap Chamarthy X-Patchwork-Id: 481935 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 55A2814018C for ; Tue, 9 Jun 2015 02:48:03 +1000 (AEST) Received: from localhost ([::1]:59255 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z20DO-0008AG-Lf for incoming@patchwork.ozlabs.org; Mon, 08 Jun 2015 12:47:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z20DA-0007ss-55 for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:47:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z20D5-0006bq-Q7 for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:47:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z20D5-0006bd-Kx for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:47:39 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 0DF848EB4A; Mon, 8 Jun 2015 16:47:38 +0000 (UTC) Received: from tesla.localdomain (ovpn-116-148.ams2.redhat.com [10.36.116.148]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t58GlZQb025433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 8 Jun 2015 12:47:36 -0400 From: Kashyap Chamarthy To: qemu-devel@nongnu.org Date: Mon, 8 Jun 2015 18:47:00 +0200 Message-Id: <1433782047-7939-1-git-send-email-kchamart@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: peter.maydell@linaro.org, rjones@redhat.com, Kashyap Chamarthy Subject: [Qemu-devel] [PATCH] qemu-sanity-check.in: Use '-display none' instead of '-nographic' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Upstream QEMU recommends to use '-display none' as opposed to '-nographic' -- which is a "legacy option that does a whole bunch of confusing stuff" (thanks Peter Maydell). Upstream libguestfs already made the switch [1] in DEC-2013. [1] https://github.com/libguestfs/libguestfs/commit/7a41f5c1 -- "launch: switch from -nographic to -display none " --- qemu-sanity-check.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-sanity-check.in b/qemu-sanity-check.in index 5bb5b292def5caff5ca63071565bd447cf5f4efd..34cd9385f56b5eedd0ec26abd128232a47e51996 100644 --- a/qemu-sanity-check.in +++ b/qemu-sanity-check.in @@ -140,7 +140,8 @@ test_output="$(mktemp --suff=.out)" declare -a argv i=0 argv[$((i++))]="$qemu" -argv[$((i++))]="-nographic" +argv[$((i++))]="-display" +argv[$((i++))]="none" argv[$((i++))]="-nodefconfig" argv[$((i++))]="-nodefaults" argv[$((i++))]="-machine"