| Message ID | 1433495103-62084-1-git-send-email-agraf@suse.de |
|---|---|
| State | New |
| Headers | show |
On Fri, Jun 5, 2015 at 11:05 AM, Alexander Graf <agraf@suse.de> wrote: > As of commit 076b35b5a (machine: add default_ram_size to machine class) we > no longer have a global default ram size, but instead machine specific > defaults. When invoking qemu --help we don't know which machine you selected, > so we can't tell the user the default RAM size in the help text anymore now. > > Thus I don't see an easy way to expose the default ram size to the user in the > help text. The easiest option IMHO is to just drop this piece of information. It's unfortunate, but I agree. Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com> Thanks, Laurent > Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> > Signed-off-by: Alexander Graf <agraf@suse.de> > --- > qemu-options.hx | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index b3db6cb..5eaba11 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -241,8 +241,7 @@ ETEXI > DEF("m", HAS_ARG, QEMU_OPTION_m, > "-m[emory] [size=]megs[,slots=n,maxmem=size]\n" > " configure guest RAM\n" > - " size: initial amount of guest memory (default: " > - stringify(DEFAULT_RAM_SIZE) "MiB)\n" > + " size: initial amount of guest memory\n" > " slots: number of hotplug slots (default: none)\n" > " maxmem: maximum amount of guest memory (default: none)\n" > "NOTE: Some architectures might enforce a specific granularity\n", > -- > 1.8.1.4 >
Alexander Graf <agraf@suse.de> writes: > As of commit 076b35b5a (machine: add default_ram_size to machine class) we > no longer have a global default ram size, but instead machine specific > defaults. When invoking qemu --help we don't know which machine you selected, > so we can't tell the user the default RAM size in the help text anymore now. > > Thus I don't see an easy way to expose the default ram size to the user in the > help text. The easiest option IMHO is to just drop this piece of information. Acked-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> > Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> > Signed-off-by: Alexander Graf <agraf@suse.de> > > --- > qemu-options.hx | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index b3db6cb..5eaba11 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -241,8 +241,7 @@ ETEXI > DEF("m", HAS_ARG, QEMU_OPTION_m, > "-m[emory] [size=]megs[,slots=n,maxmem=size]\n" > " configure guest RAM\n" > - " size: initial amount of guest memory (default: " > - stringify(DEFAULT_RAM_SIZE) "MiB)\n" > + " size: initial amount of guest memory\n" > " slots: number of hotplug slots (default: none)\n" > " maxmem: maximum amount of guest memory (default: none)\n" > "NOTE: Some architectures might enforce a specific granularity\n", > -- > 1.8.1.4
On 5 June 2015 at 10:05, Alexander Graf <agraf@suse.de> wrote: > As of commit 076b35b5a (machine: add default_ram_size to machine class) we > no longer have a global default ram size, but instead machine specific > defaults. When invoking qemu --help we don't know which machine you selected, > so we can't tell the user the default RAM size in the help text anymore now. > > Thus I don't see an easy way to expose the default ram size to the user in the > help text. The easiest option IMHO is to just drop this piece of information. > > Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> > Signed-off-by: Alexander Graf <agraf@suse.de> > --- > qemu-options.hx | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index b3db6cb..5eaba11 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -241,8 +241,7 @@ ETEXI > DEF("m", HAS_ARG, QEMU_OPTION_m, > "-m[emory] [size=]megs[,slots=n,maxmem=size]\n" > " configure guest RAM\n" > - " size: initial amount of guest memory (default: " > - stringify(DEFAULT_RAM_SIZE) "MiB)\n" > + " size: initial amount of guest memory\n" > " slots: number of hotplug slots (default: none)\n" > " maxmem: maximum amount of guest memory (default: none)\n" > "NOTE: Some architectures might enforce a specific granularity\n", Applied to master as a fix. thanks -- PMM
diff --git a/qemu-options.hx b/qemu-options.hx index b3db6cb..5eaba11 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -241,8 +241,7 @@ ETEXI DEF("m", HAS_ARG, QEMU_OPTION_m, "-m[emory] [size=]megs[,slots=n,maxmem=size]\n" " configure guest RAM\n" - " size: initial amount of guest memory (default: " - stringify(DEFAULT_RAM_SIZE) "MiB)\n" + " size: initial amount of guest memory\n" " slots: number of hotplug slots (default: none)\n" " maxmem: maximum amount of guest memory (default: none)\n" "NOTE: Some architectures might enforce a specific granularity\n",
As of commit 076b35b5a (machine: add default_ram_size to machine class) we no longer have a global default ram size, but instead machine specific defaults. When invoking qemu --help we don't know which machine you selected, so we can't tell the user the default RAM size in the help text anymore now. Thus I don't see an easy way to expose the default ram size to the user in the help text. The easiest option IMHO is to just drop this piece of information. Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> Signed-off-by: Alexander Graf <agraf@suse.de> --- qemu-options.hx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)