| Message ID | 1429793161-25677-1-git-send-email-kchamart@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 04/23/2015 06:46 AM, Kashyap Chamarthy wrote: > Although the canonical source of reference for QMP commands is > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > state the list of supported transactionable operations, namely: > > drive-backup > blockdev-backup > blockdev-snapshot-internal-sync > abort > block-dirty-bitmap-add > block-dirty-bitmap-clear > > NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-add' commands > will be available once the in-review "transactionless incremental > backup" patch series[1] is merged upstream. > > [1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.html > > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> > --- > qmp-commands.hx | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > > -Atomically operate on one or more block devices. The only supported operations > -for now are drive-backup, internal and external snapshotting. A list of > -dictionaries is accepted, that contains the actions to be performed. > -If there is any failure performing any of the operations, all operations > -for the group are abandoned. > +Atomically operate on one or more block devices. Operations that are > +currently supported: drive-backup, blockdev-backup, > +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, > +block-dirty-bitmap-add, block-dirty-bitmap-clear (refer s/refer/refer to the/ > +qemu/qapi-schema.json file for minimum required QEMU versions for these > +commands). A list of dictionaries is accepted, that contains the actions > +to be performed. If there is any failure performing any of the > +operations, all operations for the group are abandoned. > With that change, Reviewed-by: Eric Blake <eblake@redhat.com>
On Thu, Apr 23, 2015 at 05:07:44PM -0600, Eric Blake wrote: > On 04/23/2015 06:46 AM, Kashyap Chamarthy wrote: > > Although the canonical source of reference for QMP commands is > > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > > state the list of supported transactionable operations, namely: > > > > drive-backup > > blockdev-backup > > blockdev-snapshot-internal-sync > > abort > > block-dirty-bitmap-add > > block-dirty-bitmap-clear > > > > NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-add' commands Another thing I didn't notice: I enntered the same command name twice. > > will be available once the in-review "transactionless incremental > > backup" patch series[1] is merged upstream. > > > > [1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.html > > > > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> > > --- > > qmp-commands.hx | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > > > -Atomically operate on one or more block devices. The only supported operations > > -for now are drive-backup, internal and external snapshotting. A list of > > -dictionaries is accepted, that contains the actions to be performed. > > -If there is any failure performing any of the operations, all operations > > -for the group are abandoned. > > +Atomically operate on one or more block devices. Operations that are > > +currently supported: drive-backup, blockdev-backup, > > +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, > > +block-dirty-bitmap-add, block-dirty-bitmap-clear (refer > > s/refer/refer to the/ > > +qemu/qapi-schema.json file for minimum required QEMU versions for these > > +commands). A list of dictionaries is accepted, that contains the actions > > +to be performed. If there is any failure performing any of the > > +operations, all operations for the group are abandoned. > > > > With that change, > Reviewed-by: Eric Blake <eblake@redhat.com> Thanks. I'll send a v2 fixing what you found and the other mistake (double entry of the same command) in the commit message.
diff --git a/qmp-commands.hx b/qmp-commands.hx index 3a42ad0bffeb23778f877410f6e2038943da46c0..df2ab50daf2689328ed622d42f5ff129ce27cdef 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1200,11 +1200,14 @@ SQMP transaction ----------- -Atomically operate on one or more block devices. The only supported operations -for now are drive-backup, internal and external snapshotting. A list of -dictionaries is accepted, that contains the actions to be performed. -If there is any failure performing any of the operations, all operations -for the group are abandoned. +Atomically operate on one or more block devices. Operations that are +currently supported: drive-backup, blockdev-backup, +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, +block-dirty-bitmap-add, block-dirty-bitmap-clear (refer +qemu/qapi-schema.json file for minimum required QEMU versions for these +commands). A list of dictionaries is accepted, that contains the actions +to be performed. If there is any failure performing any of the +operations, all operations for the group are abandoned. For external snapshots, the dictionary contains the device, the file to use for the new snapshot, and the format. The default format, if not specified, is
Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync abort block-dirty-bitmap-add block-dirty-bitmap-clear NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-add' commands will be available once the in-review "transactionless incremental backup" patch series[1] is merged upstream. [1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.html Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> --- qmp-commands.hx | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)