From patchwork Fri Mar 27 16:55:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lin Ma X-Patchwork-Id: 455518 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D623214012F for ; Sat, 28 Mar 2015 03:56:47 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=L8+dTvA5; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from localhost ([::1]:51030 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbXYs-0005qC-2d for incoming@patchwork.ozlabs.org; Fri, 27 Mar 2015 12:56:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbXYN-0004y5-Gu for qemu-devel@nongnu.org; Fri, 27 Mar 2015 12:56:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbXYK-0000tY-90 for qemu-devel@nongnu.org; Fri, 27 Mar 2015 12:56:15 -0400 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:35554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbXYK-0000rP-22 for qemu-devel@nongnu.org; Fri, 27 Mar 2015 12:56:12 -0400 Received: by pacwz10 with SMTP id wz10so49698192pac.2 for ; Fri, 27 Mar 2015 09:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=7fMXvuvrppNVncGtVtjFmK7J842FyGILwLvgvxLQUmA=; b=L8+dTvA5obFKufca4vgWKbw5Al3I8qWvvmPM79QK6uHUCL0TJhOX+nr1Zweb0TCGI/ p5jpq17aRoY/Ock4o+Dk0XBqk6ESCvDX4jFsNgndN7M5oiXXC7IwCHRD6AnQoE0r2UN+ fOBGMoQVP1TcA7EpII/fi4tGWi/8RLXPvVk+ECm4W599XPW4iMU2yVVl1weN7y9kxz7L TSQo+cg7km8YCaekhFVP7lAdJ/KtZwDr+eFm8ApNgHnLxv1wEN/pp7z4Gc7iD1p/1bOW TNSgrp/pdRuQPNiKGkJMbJlgUxTcesRdODw9gdnyUf1h/JMQZibBVVVzcp6GeshnkDXx EZfg== X-Received: by 10.68.197.201 with SMTP id iw9mr37510580pbc.84.1427475368845; Fri, 27 Mar 2015 09:56:08 -0700 (PDT) Received: from linux-cj2w.apac.novell.com ([203.192.156.9]) by mx.google.com with ESMTPSA id z10sm2695473pas.18.2015.03.27.09.56.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 Mar 2015 09:56:08 -0700 (PDT) From: Lin Ma To: imammedo@redhat.com, afaerber@suse.de, peter.crosthwaite@xilinx.com, pbonzini@redhat.com Date: Sat, 28 Mar 2015 00:55:30 +0800 Message-Id: <1427475330-4652-3-git-send-email-lma@suse.com> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1427475330-4652-1-git-send-email-lma@suse.com> References: <1427475330-4652-1-git-send-email-lma@suse.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::230 Cc: qemu-devel@nongnu.org, Lin Ma Subject: [Qemu-devel] [PATCH v5 2/2] hostmem: Prevent removing an in-use memory backend X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org showing a memory device whose memdev is removed leads an assert: (qemu) object_add memory-backend-ram,id=ram0,size=128M (qemu) device_add pc-dimm,id=d0,memdev=ram0 (qemu) object_del ram0 (qemu) info memory-devices ** ERROR:qom/object.c:1274:object_get_canonical_path_component:\ assertion failed: (obj->parent != NULL) Aborted The patch prevents removing an in-use mem backend and error out. Signed-off-by: Lin Ma --- backends/hostmem.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/backends/hostmem.c b/backends/hostmem.c index 99e8f99..b7b6cf8 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -335,12 +335,26 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp) } } +static bool +host_memory_backend_can_be_deleted(UserCreatable *uc, Error **errp) +{ + MemoryRegion *mr; + + mr = host_memory_backend_get_memory(MEMORY_BACKEND(uc), errp); + if (memory_region_is_mapped(mr)) { + return false; + } else { + return true; + } +} + static void host_memory_backend_class_init(ObjectClass *oc, void *data) { UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc); ucc->complete = host_memory_backend_memory_complete; + ucc->can_be_deleted = host_memory_backend_can_be_deleted; } static const TypeInfo host_memory_backend_info = {