From patchwork Wed Mar 25 09:36:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wen Congyang X-Patchwork-Id: 454327 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1AE5F1400B7 for ; Wed, 25 Mar 2015 20:36:22 +1100 (AEDT) Received: from localhost ([::1]:37080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YahjY-0002TM-7Q for incoming@patchwork.ozlabs.org; Wed, 25 Mar 2015 05:36:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yahgl-00060c-W1 for qemu-devel@nongnu.org; Wed, 25 Mar 2015 05:33:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yahgl-0007sS-1Q for qemu-devel@nongnu.org; Wed, 25 Mar 2015 05:33:27 -0400 Received: from [59.151.112.132] (port=64123 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yahgk-0007mj-Li; Wed, 25 Mar 2015 05:33:26 -0400 X-IronPort-AV: E=Sophos;i="5.04,848,1406563200"; d="scan'208";a="89293795" Received: from unknown (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 25 Mar 2015 17:29:42 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id t2P9WOT3015807; Wed, 25 Mar 2015 17:32:24 +0800 Received: from G08FNSTD140052.g08.fujitsu.local (10.167.226.52) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.181.6; Wed, 25 Mar 2015 17:33:30 +0800 From: Wen Congyang To: qemu devel , Fam Zheng , Max Reitz , Paolo Bonzini Date: Wed, 25 Mar 2015 17:36:07 +0800 Message-ID: <1427276174-9130-7-git-send-email-wency@cn.fujitsu.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1427276174-9130-1-git-send-email-wency@cn.fujitsu.com> References: <1427276174-9130-1-git-send-email-wency@cn.fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.226.52] X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 59.151.112.132 Cc: Kevin Wolf , qemu block , Lai Jiangshan , Jiang Yunhong , Dong Eddie , "Dr. David Alan Gilbert" , Gonglei , Stefan Hajnoczi , Yang Hongyang , zhanghailiang Subject: [Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini --- block/nbd.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index 3faf865..753b322 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -458,6 +458,52 @@ static void nbd_refresh_filename(BlockDriverState *bs) bs->full_open_options = opts; } +static void nbd_start_replication(BlockDriverState *bs, COLOMode mode, + Error **errp) +{ + BDRVNBDState *s = bs->opaque; + + /* + * TODO: support COLO_SECONDARY_MODE if we allow secondary + * QEMU becoming primary QEMU. + */ + if (mode != COLO_MODE_PRIMARY) { + error_set(errp, QERR_INVALID_PARAMETER, "mode"); + return; + } + + if (s->connected) { + error_setg(errp, "The connection is established"); + return; + } + + /* TODO: NBD client should be one child of quorum, how to verify it? */ + nbd_connect_server(bs, errp); +} + +static void nbd_do_checkpoint(BlockDriverState *bs, Error **errp) +{ + BDRVNBDState *s = bs->opaque; + + if (!s->connected) { + error_setg(errp, "The connection is not established"); + return; + } +} + +static void nbd_stop_replication(BlockDriverState *bs, Error **errp) +{ + BDRVNBDState *s = bs->opaque; + + if (!s->connected) { + error_setg(errp, "The connection is not established"); + return; + } + + nbd_client_close(bs); + s->connected = false; +} + static BlockDriver bdrv_nbd = { .format_name = "nbd", .protocol_name = "nbd", @@ -527,6 +573,9 @@ static BlockDriver bdrv_nbd_colo = { .bdrv_detach_aio_context = nbd_detach_aio_context, .bdrv_attach_aio_context = nbd_attach_aio_context, .bdrv_refresh_filename = nbd_refresh_filename, + .bdrv_start_replication = nbd_start_replication, + .bdrv_do_checkpoint = nbd_do_checkpoint, + .bdrv_stop_replication = nbd_stop_replication, .has_variable_length = true, };