From patchwork Wed Feb 11 03:06:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Liang Z" X-Patchwork-Id: 438665 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3E71714012A for ; Wed, 11 Feb 2015 14:22:43 +1100 (AEDT) Received: from localhost ([::1]:42936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLNsu-0000m5-S4 for incoming@patchwork.ozlabs.org; Tue, 10 Feb 2015 22:22:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLNlk-0004pa-Cw for qemu-devel@nongnu.org; Tue, 10 Feb 2015 22:15:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLNlc-0000cz-R5 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 22:15:16 -0500 Received: from mga11.intel.com ([192.55.52.93]:43143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLNlc-0000UZ-G9 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 22:15:08 -0500 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 10 Feb 2015 19:15:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,555,1418112000"; d="scan'208";a="452911923" Received: from lil.sh.intel.com (HELO localhost) ([10.239.159.167]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2015 19:00:29 -0800 From: Liang Li To: qemu-devel@nongnu.org Date: Wed, 11 Feb 2015 11:06:22 +0800 Message-Id: <1423623986-590-9-git-send-email-liang.z.li@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1423623986-590-1-git-send-email-liang.z.li@intel.com> References: <1423623986-590-1-git-send-email-liang.z.li@intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.93 Cc: quintela@redhat.com, Liang Li , armbru@redhat.com, lcapitulino@redhat.com, Yang Zhang , amit.shah@redhat.com, dgilbert@redhat.com Subject: [Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Implement the core logic of the multiple thread compression. At this point, multiple thread compression can't co-work with xbzrle yet. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- arch_init.c | 193 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 185 insertions(+), 8 deletions(-) diff --git a/arch_init.c b/arch_init.c index fe062db..17b7f15 100644 --- a/arch_init.c +++ b/arch_init.c @@ -363,18 +363,44 @@ static QemuMutex *comp_done_lock; static QemuCond *comp_done_cond; /* The empty QEMUFileOps will be used by file in CompressParam */ static const QEMUFileOps empty_ops = { }; + +/* one_byte_count is used to count the bytes that is added to + * bytes_transferred but not actually transferred, at the proper + * time, we should sub one_byte_count from bytes_transferred to + * make bytes_transferred accurate. + */ +static int one_byte_count; static bool quit_comp_thread; static bool quit_decomp_thread; static DecompressParam *decomp_param; static QemuThread *decompress_threads; static uint8_t *compressed_data_buf; +static int do_compress_ram_page(CompressParam *param); + static void *do_data_compress(void *opaque) { - while (!quit_comp_thread) { - - /* To be done */ + CompressParam *param = opaque; + while (!quit_comp_thread) { + qemu_mutex_lock(¶m->mutex); + /* Re-check the quit_comp_thread in case of + * terminate_compression_threads is called just before + * qemu_mutex_lock(¶m->mutex) and after + * while(!quit_comp_thread), re-check it here can make + * sure the compression thread terminate as expected. + */ + while (!param->busy && !quit_comp_thread) { + qemu_cond_wait(¶m->cond, ¶m->mutex); + } + qemu_mutex_unlock(¶m->mutex); + if (!quit_comp_thread) { + do_compress_ram_page(param); + } + qemu_mutex_lock(comp_done_lock); + param->busy = false; + qemu_cond_signal(comp_done_cond); + qemu_mutex_unlock(comp_done_lock); } return NULL; @@ -382,9 +408,15 @@ static void *do_data_compress(void *opaque) static inline void terminate_compression_threads(void) { - quit_comp_thread = true; + int idx, thread_count; - /* To be done */ + thread_count = migrate_compress_threads(); + quit_comp_thread = true; + for (idx = 0; idx < thread_count; idx++) { + qemu_mutex_lock(&comp_param[idx].mutex); + qemu_cond_signal(&comp_param[idx].cond); + qemu_mutex_unlock(&comp_param[idx].mutex); + } } void migrate_compress_threads_join(MigrationState *s) @@ -770,12 +802,157 @@ static int ram_save_page(QEMUFile *f, RAMBlock *block, ram_addr_t offset, return bytes_sent; } +static int do_compress_ram_page(CompressParam *param) +{ + int bytes_sent, cont; + int blen; + uint8_t *p; + RAMBlock *block = param->block; + ram_addr_t offset = param->offset; + + cont = (block == last_sent_block) ? RAM_SAVE_FLAG_CONTINUE : 0; + p = memory_region_get_ram_ptr(block->mr) + offset; + + bytes_sent = save_block_hdr(param->file, block, offset, cont, + RAM_SAVE_FLAG_COMPRESS_PAGE); + blen = qemu_put_compression_data(param->file, p, TARGET_PAGE_SIZE, + migrate_compress_level()); + bytes_sent += blen; + atomic_inc(&acct_info.norm_pages); + + return bytes_sent; +} + +static inline void start_compression(CompressParam *param) +{ + qemu_mutex_lock(¶m->mutex); + param->busy = true; + qemu_cond_signal(¶m->cond); + qemu_mutex_unlock(¶m->mutex); +} + + +static uint64_t bytes_transferred; + +static void flush_compressed_data(QEMUFile *f) +{ + int idx, len, thread_count; + + if (!migrate_use_compression()) { + return; + } + thread_count = migrate_compress_threads(); + for (idx = 0; idx < thread_count; idx++) { + if (comp_param[idx].busy) { + qemu_mutex_lock(comp_done_lock); + while (comp_param[idx].busy && !quit_comp_thread) { + qemu_cond_wait(comp_done_cond, comp_done_lock); + } + qemu_mutex_unlock(comp_done_lock); + } + len = qemu_put_qemu_file(f, comp_param[idx].file); + bytes_transferred += len; + } + if ((one_byte_count > 0) && (bytes_transferred > one_byte_count)) { + bytes_transferred -= one_byte_count; + one_byte_count = 0; + } +} + +static inline void set_compress_params(CompressParam *param, RAMBlock *block, + ram_addr_t offset) +{ + param->block = block; + param->offset = offset; +} + +static int compress_page_with_multi_thread(QEMUFile *f, RAMBlock *block, + ram_addr_t offset) +{ + int idx, thread_count, bytes_sent = 0; + + thread_count = migrate_compress_threads(); + qemu_mutex_lock(comp_done_lock); + while (true) { + for (idx = 0; idx < thread_count; idx++) { + if (!comp_param[idx].busy) { + bytes_sent = qemu_put_qemu_file(f, comp_param[idx].file); + set_compress_params(&comp_param[idx], block, offset); + start_compression(&comp_param[idx]); + if (bytes_sent == 0) { + /* set bytes_sent to 1 in this case to prevent migration + * from terminating, this 1 byte will be added to + * bytes_transferred later, minus 1 to keep the + * bytes_transferred accurate */ + bytes_sent = 1; + if (bytes_transferred <= 0) { + one_byte_count++; + } else { + bytes_transferred -= 1; + } + } + break; + } + } + if (bytes_sent > 0) { + break; + } else { + qemu_cond_wait(comp_done_cond, comp_done_lock); + } + } + qemu_mutex_unlock(comp_done_lock); + + return bytes_sent; +} + static int ram_save_compressed_page(QEMUFile *f, RAMBlock *block, ram_addr_t offset, bool last_stage) { int bytes_sent = -1; + MemoryRegion *mr = block->mr; + uint8_t *p; + int ret; + int cont; - /* To be done*/ + p = memory_region_get_ram_ptr(mr) + offset; + cont = (block == last_sent_block) ? RAM_SAVE_FLAG_CONTINUE : 0; + ret = ram_control_save_page(f, block->offset, + offset, TARGET_PAGE_SIZE, &bytes_sent); + if (ret != RAM_SAVE_CONTROL_NOT_SUPP) { + if (ret != RAM_SAVE_CONTROL_DELAYED) { + if (bytes_sent > 0) { + acct_info.norm_pages++; + } else if (bytes_sent == 0) { + acct_info.dup_pages++; + } + } + } else { + /* When starting the process of a new block, the first page of + * the block should be sent out before other pages in the same + * block, and all the pages in last block should have been sent + * out, keeping this order is important, because the 'cont' flag + * is used to avoid resending the block name. + */ + if (block != last_sent_block) { + flush_compressed_data(f); + bytes_sent = save_zero_page(f, block, offset, p, cont); + if (bytes_sent == -1) { + set_compress_params(&comp_param[0], block, offset); + /* Use the qemu thread to compress the data to make sure the + * first page is sent out before other pages + */ + bytes_sent = do_compress_ram_page(&comp_param[0]); + if (bytes_sent > 0) { + qemu_put_qemu_file(f, comp_param[0].file); + } + } + } else { + bytes_sent = save_zero_page(f, block, offset, p, cont); + if (bytes_sent == -1) { + bytes_sent = compress_page_with_multi_thread(f, block, offset); + } + } + } return bytes_sent; } @@ -834,8 +1011,6 @@ static int ram_find_and_save_block(QEMUFile *f, bool last_stage) return bytes_sent; } -static uint64_t bytes_transferred; - void acct_update_position(QEMUFile *f, size_t size, bool zero) { uint64_t pages = size / TARGET_PAGE_SIZE; @@ -1043,6 +1218,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque) i++; } + flush_compressed_data(f); qemu_mutex_unlock_ramlist(); /* @@ -1089,6 +1265,7 @@ static int ram_save_complete(QEMUFile *f, void *opaque) bytes_transferred += bytes_sent; } + flush_compressed_data(f); ram_control_after_iterate(f, RAM_CONTROL_FINISH); migration_end();