| Message ID | 1415641462-52468-4-git-send-email-agraf@suse.de |
|---|---|
| State | New |
| Headers | show |
On 10 November 2014 17:44, Alexander Graf <agraf@suse.de> wrote: > The timer_gettime and timer_settime syscalls get a timer_t parameter. Since > we now have an internal wrapper type for it, let's make use of it. > > We do not need to check for signed < 0 overflows, because we already mask out > the upper bits of the value, rendering the number always unsigned. > > Signed-off-by: Alexander Graf <agraf@suse.de> Personally I think these three patches would actually be easier to review merged into a single patch at this point. -- PMM
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index b7f12b6..96d74df 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -9617,7 +9617,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, { /* args: timer_t timerid, int flags, const struct itimerspec *new_value, * struct itimerspec * old_value */ - target_ulong timerid = arg1; + target_timer_t timerid = arg1; /* Convert QEMU provided timer ID back to internal 16bit index format */ if ((timerid & TIMER_MAGIC_MASK) == TIMER_MAGIC) { @@ -9646,7 +9646,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, case TARGET_NR_timer_gettime: { /* args: timer_t timerid, struct itimerspec *curr_value */ - target_ulong timerid = arg1; + target_timer_t timerid = arg1; /* Convert QEMU provided timer ID back to internal 16bit index format */ if ((timerid & TIMER_MAGIC_MASK) == TIMER_MAGIC) {
The timer_gettime and timer_settime syscalls get a timer_t parameter. Since we now have an internal wrapper type for it, let's make use of it. We do not need to check for signed < 0 overflows, because we already mask out the upper bits of the value, rendering the number always unsigned. Signed-off-by: Alexander Graf <agraf@suse.de> --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)