From patchwork Wed Nov 5 14:43:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 407014 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 410BF140079 for ; Thu, 6 Nov 2014 01:44:08 +1100 (AEDT) Received: from localhost ([::1]:46800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm1ob-0006ir-VH for incoming@patchwork.ozlabs.org; Wed, 05 Nov 2014 09:44:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm1oB-0006S5-AJ for qemu-devel@nongnu.org; Wed, 05 Nov 2014 09:43:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm1nx-0002YN-1o for qemu-devel@nongnu.org; Wed, 05 Nov 2014 09:43:39 -0500 Received: from mail-lb0-x22b.google.com ([2a00:1450:4010:c04::22b]:42909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm1nw-0002Xl-My for qemu-devel@nongnu.org; Wed, 05 Nov 2014 09:43:24 -0500 Received: by mail-lb0-f171.google.com with SMTP id b6so779893lbj.16 for ; Wed, 05 Nov 2014 06:43:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=afOjFw9C1YO4OiOmpHvXcw8Sho7UCwdLWdBT1ntEMgE=; b=rty1w7kf19IhXDcXhgSncUPyC1csPnUMi2R1dHF4iDoyQn6Sbw63JVtuQaE5MJ3wdb W+Zb+WEPEiSCNPamjda6Dd7Vs27JMnKAFQpYFch9EGSBT+tCx7OscNR6pKL/OkL/2+Co eHEXjRacTz3eQWk3ZZcMd7FMNsYGX8L7eWPw3aNeYXhl7qTOamOYRhuofPTDteS20iVh TXN+f8YbLLYcjRL6GesTAPMFvaEcrhLzC7QWKOcIxDqcGeG6oRvFZlz5fcJpjLJoW8Mz 9UmAtrx3ai2TB5HFwxLOw74P6+etwtUKdfNqZ/kp/VKA5Wdic9ebK+4++l7fI99VKrKX g8Aw== X-Received: by 10.152.198.199 with SMTP id je7mr38910821lac.25.1415198602416; Wed, 05 Nov 2014 06:43:22 -0800 (PST) Received: from localhost (nat-pool-cdg-t.redhat.com. [209.132.186.20]) by mx.google.com with ESMTPSA id ny6sm1396548lbb.2.2014.11.05.06.43.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Nov 2014 06:43:21 -0800 (PST) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Wed, 5 Nov 2014 15:43:14 +0100 Message-Id: <1415198594-32581-1-git-send-email-marcandre.lureau@gmail.com> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22b Cc: amit.shah@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [Qemu-devel] [PATCHv2] virtio-serial: avoid crash when port has no name X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It seems "name" is not mandatory, and the following command line (based on one generated by current libvirt) will crash qemu at start: qemu-system-x86_64 \ -device virtio-serial-pci \ -device virtserialport,name=foo \ -device virtconsole Program received signal SIGSEGV, Segmentation fault. __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210 210 movlpd (%rsi), %xmm2 Missing separate debuginfos, use: debuginfo-install python-libs-2.7.5-13.fc20.x86_64 (gdb) bt #0 __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210 #1 0x000055555566bdc6 in find_port_by_name (name=0x0) at /home/elmarco/src/qemu/hw/char/virtio-serial-bus.c:67 Signed-off-by: Marc-André Lureau Reviewed-by: Amos Kong --- hw/char/virtio-serial-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 3931085..f16452e 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial-bus.c @@ -871,7 +871,7 @@ static void virtser_port_device_realize(DeviceState *dev, Error **errp) return; } - if (find_port_by_name(port->name)) { + if (port->name != NULL && find_port_by_name(port->name)) { error_setg(errp, "virtio-serial-bus: A port already exists by name %s", port->name); return;