From patchwork Thu Jun 26 11:45:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kirill Batuzov X-Patchwork-Id: 364507 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3CCA5140078 for ; Thu, 26 Jun 2014 21:46:20 +1000 (EST) Received: from localhost ([::1]:43819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X088A-0003kf-FX for incoming@patchwork.ozlabs.org; Thu, 26 Jun 2014 07:46:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X087Y-000374-6f for qemu-devel@nongnu.org; Thu, 26 Jun 2014 07:45:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X087R-0001VT-Bf for qemu-devel@nongnu.org; Thu, 26 Jun 2014 07:45:40 -0400 Received: from smtp.ispras.ru ([83.149.199.79]:51597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X087R-0001VG-2n for qemu-devel@nongnu.org; Thu, 26 Jun 2014 07:45:33 -0400 Received: from bulbul.intra.ispras.ru (unknown [83.149.199.91]) by smtp.ispras.ru (Postfix) with ESMTP id 5B0C0224AB; Thu, 26 Jun 2014 15:45:31 +0400 (MSK) From: Kirill Batuzov To: qemu-devel@nongnu.org Date: Thu, 26 Jun 2014 15:45:11 +0400 Message-Id: <1403783111-28592-1-git-send-email-batuzovk@ispras.ru> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.79 Cc: Nikita Belov , Paolo Bonzini , Luiz Capitulino , Fam Zheng , Kirill Batuzov Subject: [Qemu-devel] [PATCH] qemu-char: initialize chr_write_lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org chr_write_lock was introduced in commit 9005b2a7589540a3733b3abdcfbccfe7746cd1a1 but was used uninitialized. It caused segmentation fault on windows hosts. Add missing lock initialization to qemu_chr_alloc. Cc: Paolo Bonzini Cc: Luiz Capitulino Cc: Fam Zheng Signed-off-by: Kirill Batuzov Signed-off-by: Nikita Belov --- qemu-char.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-char.c b/qemu-char.c index 2e50a10..17bd360 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -94,6 +94,7 @@ static QTAILQ_HEAD(CharDriverStateHead, CharDriverState) chardevs = CharDriverState *qemu_chr_alloc(void) { CharDriverState *chr = g_malloc0(sizeof(CharDriverState)); + qemu_mutex_init(&chr->chr_write_lock); return chr; }