From patchwork Mon Jun 23 14:30:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 362943 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D555D14007C for ; Tue, 24 Jun 2014 00:31:59 +1000 (EST) Received: from localhost ([::1]:53882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz5Hp-0000yI-Ry for incoming@patchwork.ozlabs.org; Mon, 23 Jun 2014 10:31:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz5HM-0000JO-7w for qemu-devel@nongnu.org; Mon, 23 Jun 2014 10:31:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz5HG-0003h9-BP for qemu-devel@nongnu.org; Mon, 23 Jun 2014 10:31:28 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:37858 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz5HG-0003gG-1i for qemu-devel@nongnu.org; Mon, 23 Jun 2014 10:31:22 -0400 Received: (qmail 16346 invoked by uid 89); 23 Jun 2014 14:31:19 -0000 Received: from [82.141.1.145] by client-16-kamp (envelope-from , uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.98.4/19123. hbedv: 8.3.20.14/7.11.156.52. spamassassin: 3.4.0. Clear:RC:1(82.141.1.145):SA:0(-1.2/5.0):. Processed in 1.886374 secs); 23 Jun 2014 14:31:19 -0000 Received: from ns.kamp-intra.net (HELO dns.kamp-intra.net) ([82.141.1.145]) by mx01.kamp.de with SMTP; 23 Jun 2014 14:31:17 -0000 X-GL_Whitelist: yes Received: from lieven-pc.kamp-intra.net (lieven-pc.kamp-intra.net [172.21.12.60]) by dns.kamp-intra.net (Postfix) with ESMTP id 5ECC920020; Mon, 23 Jun 2014 16:30:37 +0200 (CEST) Received: by lieven-pc.kamp-intra.net (Postfix, from userid 1000) id 558FE61A87; Mon, 23 Jun 2014 16:30:37 +0200 (CEST) From: Peter Lieven To: qemu-devel@nongnu.org Date: Mon, 23 Jun 2014 16:30:36 +0200 Message-Id: <1403533836-28589-1-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.7.9.5 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a02:248:0:51::16 Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven , ronniesahlberg@gmail.com, stefanha@redhat.com Subject: [Qemu-devel] [PATCH] block/nfs: add knob to set readahead X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org upcoming libnfs will feature internal readahead support. Add a knob to pass the optional readahead value as a URL parameter. This patch fixes also the incorrect usage of strncmp. Signed-off-by: Peter Lieven --- block/nfs.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index ec43201..a5c0577 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -309,12 +309,16 @@ static int64_t nfs_client_open(NFSClient *client, const char *filename, qp->p[i].name); goto fail; } - if (!strncmp(qp->p[i].name, "uid", 3)) { + if (!strcmp(qp->p[i].name, "uid")) { nfs_set_uid(client->context, atoi(qp->p[i].value)); - } else if (!strncmp(qp->p[i].name, "gid", 3)) { + } else if (!strcmp(qp->p[i].name, "gid")) { nfs_set_gid(client->context, atoi(qp->p[i].value)); - } else if (!strncmp(qp->p[i].name, "tcp-syncnt", 10)) { + } else if (!strcmp(qp->p[i].name, "tcp-syncnt")) { nfs_set_tcp_syncnt(client->context, atoi(qp->p[i].value)); +#ifdef LIBNFS_FEATURE_READAHEAD + } else if (!strcmp(qp->p[i].name, "readahead")) { + nfs_set_readahead(client->context, atoi(qp->p[i].value)); +#endif } else { error_setg(errp, "Unknown NFS parameter name: %s", qp->p[i].name);